feat: Add option to not modify readonly files during copy, add logging of time

[TatuLund]

Allows to skip setting the writable flag on copied files, by providing the vaadin.frontend.disableWritableFlagCheckOnCopy system property.
This may improve performance in certain scenarios with Windows OS.

Fixes #19866

[thomasharre]

@TatuLund you have changed the default behaviour, I only wanted a possibility to turn it of.
I suggest changing:
PREVENT_READONLY_FILES = true;

[github-actions]

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 25m 54s ⏱️ - 8m 41s
7 392 tests ± 0  7 342 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 705 runs   - 57  7 645 ✅  - 57  60 💤 ±0  0 ❌ ±0 

Results for commit a30a754. ± Comparison against base commit 4b91372.

♻️ This comment has been updated with latest results.

[TatuLund]

@thomasharre Thanks for spotting that. I was testing this locally changing the value back and forth, it was wrong value by accident.

[mcollovati]

What's the idea behind the usage of the static field? Is the developer supposed to change it in the application code?
If so, this will work for development mode, but will not help when the task is executed by Maven or Gradle.
Could a system property be a better option?

[TatuLund]

Could a system property be a better option?

Yes it would.

[thomasharre]

We are only experiencing problems in certain developer environements.
Therefor the static field is the most pragmatic solution for us.

A system property would also work, but the current solution with public static field would be a fast way to help us.

[mcollovati]

I still would prefer a system property, instead of the static field. Something like vaadin.frontend.disableReadonlyCheckOnCopy (feel free to suggest a better name), to make explicit that we are disabling an operation that was added to fix application failures (for example #12711)

[thomasharre]

A system property would also work fine for me.

So the code in copyLocalResources would be something like?
boolean performReadonlyCheck = !Boolean.valueOf(System.getProperty("vaadin.frontend.disableReadonlyCheckOnCopy", "false")); if (performReadonlyCheck){ ... }

@TatuLund would that suit you? If yes, could you please commit that?

[thomasharre]

@TatuLund the member 'performReadonlyCheck' should not be static

[TatuLund]

the member 'performReadonlyCheck' should not be static

@thomasharre No, it must be as the method where it is used is static

[thomasharre]

@TatuLund
setting a static member in the constructor can't be right
then i would delete the member and introduce a new static method:

private static boolean performReadonlyCheck(){ return !Boolean.valueOf(System.getProperty("vaadin.frontend.disableReadonlyCheckOnCopy", "false")); }

[TatuLund]

@thomasharre Both work, but you are right it is cleaner version. Funny that Sonar did not complain about it.

[thomasharre]

@TatuLund thanks

@mcollovati could you take another look and descide if this can be merged?

[mcollovati]

Just a comment about naming, other than that LGTM

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.5.0.alpha16 and is also targeting the upcoming stable 24.5.0 version.