-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support direct rule evaluation with validator check --direct
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… edge cases & fix FatalCLI calls Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
force-pushed
the
feat/check-direct
branch
from
August 5, 2024 23:17
c54cd35
to
5fe7096
Compare
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
new-feature
Net-new feature
labels
Aug 6, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
approved these changes
Aug 6, 2024
TylerGillson
added a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.6...v0.1.0) (2024-08-06) ### ⚠ BREAKING CHANGES * split plugin rule configuration and installation into separate commands ([#121](#121)) ### Features * add docs command; refactor to use embeddedfs pkg ([#116](#116)) ([dbe19c5](dbe19c5)) * read CA certs for network rules, add HTTPFileRules, AMIRules ([#117](#117)) ([0c4487f](0c4487f)) * support direct rule evaluation with `validator check --direct` ([#127](#127)) ([f1fb0d6](f1fb0d6)) ### Docs * added subcommands docs page ([#110](#110)) ([9fa23dc](9fa23dc)) ### Dependency Updates * **deps:** update github.com/validator-labs/validator-plugin-azure digest to ba947e3 ([#134](#134)) ([2a1058d](2a1058d)) * **deps:** update github.com/validator-labs/validator-plugin-vsphere digest to 9b1f05b ([#135](#135)) ([253f328](253f328)) ### Refactoring * remove -s flag ([#126](#126)) ([9373e02](9373e02)) * simplify helm prompts ([#115](#115)) ([8ce75a1](8ce75a1)) * split plugin rule configuration and installation into separate commands ([#121](#121)) ([6eaee77](6eaee77)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
This PR has been approved by a maintainer
new-feature
Net-new feature
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #102
Description
Adds
--direct
flag forvalidator check
. In direct mode, no K8s cluster is required.Instead, plugin rules are evaluated directly, in-process. Results are both saved to disk and printed to the console.