refactor: simplify helm prompts #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-ibra
force-pushed
the
refactor/helm-config
branch
from
7aebac9
to
b61da5a
Compare
ahmad-ibra
added a commit
to validator-labs/validator
that referenced
this pull request
Aug 1, 2024
…harts are installed (#359) ## Description In validatorctl, when configuring a custom private registry, pulling the plugin charts fails with this error: ``` 2024-07-31 18:34:22 ERROR Plugin failed to install └ validator-plugin-network: failed to pull chart: failed to fetch image from registry: GET https://toolbox.palette-adv.spectrocloud.com/v2/ahmad/charts/validator-plugin-network/validator-plugin-network/manifests/0.0.21: NOT_FOUND: repository ahmad/charts/validator-plugin-network/validator-plugin-network not found ``` As can be seen above, there is an extra `/validator-plugin-network` tacked on at the end. This PR fixes that. This PR is a pre-requisite to validator-labs/validatorctl#115 ## Test Notes Tested this by: 1. running `helm install validator chart/validator/ -f chart/validator/values.yaml` 2. running `./bin/validator install` and configuring a plugin using the default registry (quay) 3. running `./bin/validator install` and configuring a plugin using a custom private registry (harbor) Everything runs correctly with this change. Prior to this change, test 3 was failing.
ahmad-ibra
added a commit
to validator-labs/validator
that referenced
this pull request
Aug 1, 2024
…harts are installed (#359) ## Description In validatorctl, when configuring a custom private registry, pulling the plugin charts fails with this error: ``` 2024-07-31 18:34:22 ERROR Plugin failed to install └ validator-plugin-network: failed to pull chart: failed to fetch image from registry: GET https://toolbox.palette-adv.spectrocloud.com/v2/ahmad/charts/validator-plugin-network/validator-plugin-network/manifests/0.0.21: NOT_FOUND: repository ahmad/charts/validator-plugin-network/validator-plugin-network not found ``` As can be seen above, there is an extra `/validator-plugin-network` tacked on at the end. This PR fixes that. This PR is a pre-requisite to validator-labs/validatorctl#115 ## Test Notes Tested this by: 1. running `helm install validator chart/validator/ -f chart/validator/values.yaml` 2. running `./bin/validator install` and configuring a plugin using the default registry (quay) 3. running `./bin/validator install` and configuring a plugin using a custom private registry (harbor) Everything runs correctly with this change. Prior to this change, test 3 was failing.
ahmad-ibra
force-pushed
the
refactor/helm-config
branch
from
d9e1c04
to
53a8bfc
Compare
ahmad-ibra
commented
Aug 1, 2024
dosubot
bot
added
size:XL
TylerGillson
reviewed
Aug 1, 2024
TylerGillson
approved these changes
Aug 1, 2024
TylerGillson
added a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.6...v0.1.0) (2024-08-06) ### ⚠ BREAKING CHANGES * split plugin rule configuration and installation into separate commands ([#121](#121)) ### Features * add docs command; refactor to use embeddedfs pkg ([#116](#116)) ([dbe19c5](dbe19c5)) * read CA certs for network rules, add HTTPFileRules, AMIRules ([#117](#117)) ([0c4487f](0c4487f)) * support direct rule evaluation with `validator check --direct` ([#127](#127)) ([f1fb0d6](f1fb0d6)) ### Docs * added subcommands docs page ([#110](#110)) ([9fa23dc](9fa23dc)) ### Dependency Updates * **deps:** update github.com/validator-labs/validator-plugin-azure digest to ba947e3 ([#134](#134)) ([2a1058d](2a1058d)) * **deps:** update github.com/validator-labs/validator-plugin-vsphere digest to 9b1f05b ([#135](#135)) ([253f328](253f328)) ### Refactoring * remove -s flag ([#126](#126)) ([9373e02](9373e02)) * simplify helm prompts ([#115](#115)) ([8ce75a1](8ce75a1)) * split plugin rule configuration and installation into separate commands ([#121](#121)) ([6eaee77](6eaee77)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #100
Description
Add support for configuring helm via the new
helmConfigand updatedhelmReleasestructs from validator. This greatly reduces the amount of prompts users need to make their way through to actually deploy the validator with any plugin.Tests
Out of scope
I've intentionally NOT implemented changes to handle PLT-1300. There are some TODO's littered throughout the codebase still that relate to that issue.