-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove -s flag #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
bug
Something isn't working
labels
Aug 2, 2024
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 36.96% 36.86% -0.10%
==========================================
Files 44 44
Lines 5119 5119
==========================================
- Hits 1892 1887 -5
- Misses 2882 2885 +3
- Partials 345 347 +2
Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
force-pushed
the
fix/validator-flags
branch
from
August 3, 2024 01:23
30707e7
to
dab4db5
Compare
ahmad-ibra
changed the title
fix: ensure validator install -s and -r flags are mutually exclusive
refactor:
Aug 3, 2024
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
refactoring
Refactoring / tech debt
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Aug 3, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Aug 3, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
approved these changes
Aug 3, 2024
TylerGillson
added a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.6...v0.1.0) (2024-08-06) ### ⚠ BREAKING CHANGES * split plugin rule configuration and installation into separate commands ([#121](#121)) ### Features * add docs command; refactor to use embeddedfs pkg ([#116](#116)) ([dbe19c5](dbe19c5)) * read CA certs for network rules, add HTTPFileRules, AMIRules ([#117](#117)) ([0c4487f](0c4487f)) * support direct rule evaluation with `validator check --direct` ([#127](#127)) ([f1fb0d6](f1fb0d6)) ### Docs * added subcommands docs page ([#110](#110)) ([9fa23dc](9fa23dc)) ### Dependency Updates * **deps:** update github.com/validator-labs/validator-plugin-azure digest to ba947e3 ([#134](#134)) ([2a1058d](2a1058d)) * **deps:** update github.com/validator-labs/validator-plugin-vsphere digest to 9b1f05b ([#135](#135)) ([253f328](253f328)) ### Refactoring * remove -s flag ([#126](#126)) ([9373e02](9373e02)) * simplify helm prompts ([#115](#115)) ([8ce75a1](8ce75a1)) * split plugin rule configuration and installation into separate commands ([#121](#121)) ([6eaee77](6eaee77)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
This PR has been approved by a maintainer
refactoring
Refactoring / tech debt
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The proposal of this PR is to simplify our command API by reducing the number of flags we have and using the same flags in different commands.
Namely, this PR focuses on the
--silent
and--reconfigure
flags. Instead of having both flags available for theNewInstallValidatorCmd
andNewConfigureValidatorCmd
, we can reduce to just using the--reconfigure
flag in both commands.The implications of these changes are this:
-f
is used in either the Install or Configure command => silent mode (ie no TUI prompts)-f
and-r
are used in conjuncture in either the Install or Configure command => reconfigure mode (interactive but with defaults from the config provided to users)--check
), they'll need to run the check command as follows to update their plugin rules:validator check -f validator.yaml -r
Tests
Ran the following:
validator install --check
=> interactive on both install and configure sidevalidator install --check -f validator.yaml
=> silent on both install and configure sidevalidator install --check -f validator.yaml -r
=> reconfigure mode on both install and configure side