-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update executePlugins
function to operate on a slice of PluginSpec
's
#206
Merged
+266
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-ibra
force-pushed
the
feat/add-crd-flag
branch
from
September 3, 2024 20:11
a4e317d
to
99a026f
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 53.33% 53.33% -0.01%
==========================================
Files 45 45
Lines 6253 6272 +19
==========================================
+ Hits 3335 3345 +10
- Misses 2073 2082 +9
Partials 845 845
Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
force-pushed
the
feat/add-crd-flag
branch
2 times, most recently
from
September 4, 2024 17:59
51a0b2a
to
e06b7b5
Compare
ahmad-ibra
changed the title
feat: add --crd flag to the check command and set as mutually exclusive
refactor: update Sep 4, 2024
executePlugins
function to operate on a slice of PluginSpec
's
ahmad-ibra
force-pushed
the
feat/add-crd-flag
branch
7 times, most recently
from
September 5, 2024 18:50
d32c11f
to
98960e0
Compare
…s, remove validatorctl versions of the functions
…alidatorctl version of the function
ahmad-ibra
force-pushed
the
feat/add-crd-flag
branch
from
September 5, 2024 18:51
98960e0
to
4302cb2
Compare
ahmad-ibra
force-pushed
the
feat/add-crd-flag
branch
from
September 5, 2024 22:23
f3497a3
to
974acc3
Compare
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
refactoring
Refactoring / tech debt
labels
Sep 5, 2024
ahmad-ibra
force-pushed
the
feat/add-crd-flag
branch
from
September 5, 2024 22:50
e5f5a70
to
4e6554b
Compare
ahmad-ibra
force-pushed
the
feat/add-crd-flag
branch
from
September 5, 2024 23:06
4e6554b
to
eb7ece1
Compare
TylerGillson
approved these changes
Sep 6, 2024
TylerGillson
added a commit
that referenced
this pull request
Sep 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](v0.1.4...v0.2.0) (2024-09-11) ### ⚠ BREAKING CHANGES * remove role privilege rules ([#217](#217)) ### Features * add --custom-resources flag to validator rules check as an alternate to -f ([#218](#218)) ([4aa14b6](4aa14b6)) ### Bug Fixes * add missing Host.Config.Storage privilege & document ([#212](#212)) ([c7408a6](c7408a6)) ### Docs * remove subcommand docs from repo ([#205](#205)) ([57ca6cb](57ca6cb)) ### Dependency Updates * **deps:** update golang.org/x/exp digest to e7e105d ([#214](#214)) ([c4ac163](c4ac163)) ### Refactoring * remove role privilege rules ([#217](#217)) ([b0976db](b0976db)) * update `executePlugins` function to operate on a slice of `PluginSpec`'s ([#206](#206)) ([97875f3](97875f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
This PR has been approved by a maintainer
refactoring
Refactoring / tech debt
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #211
Description
The purpose of this PR is to refactor the
executePlugin
function to operate on a slice ofPluginSpec
's as opposed to aValidatorConfig
. This is prep work to help us soon support the--crd
flag where users will be able to pass in CRs for various validation rules.In the process of making these changes, I updated the oci and network plugins to fully support direct invocation of rules that previously required k8s secrets. Now those credentials/pubkeys that were defined in secrets can be defined inline within the oci and network plugin specs. To get this fully working, this PR also includes changes to: