Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure validatorctl #1

Merged
merged 36 commits into from
Jun 11, 2024
Merged

feat: configure validatorctl #1

merged 36 commits into from
Jun 11, 2024

Conversation

ahmad-ibra
Copy link
Collaborator

No description provided.

@ahmad-ibra ahmad-ibra force-pushed the feat/setup-cli branch 2 times, most recently from c5b0b05 to 350dfc3 Compare June 4, 2024 21:53
@ahmad-ibra ahmad-ibra marked this pull request as ready for review June 10, 2024 22:32
@ahmad-ibra ahmad-ibra requested review from a team and TylerGillson June 10, 2024 22:32
TylerGillson
TylerGillson previously approved these changes Jun 10, 2024
View reviewed changes
TylerGillson
TylerGillson previously approved these changes Jun 10, 2024
View reviewed changes
@ahmad-ibra ahmad-ibra merged commit 34285c6 into main Jun 11, 2024
7 checks passed
@ahmad-ibra ahmad-ibra deleted the feat/setup-cli branch June 11, 2024 01:06
This was referenced Jun 19, 2024
Merged
Closed
Closed
Merged
Closed
Merged
TylerGillson pushed a commit that referenced this pull request Jul 26, 2024
@mattwelke
feat: Azure plugin - remove Palette presets, reading permission set f…
95787db 
…iles (#97)

## Issue
Resolves #84
Resolves #45

## Description
Changes the plugin to not have Palette presets for Azure RBAC rules
anymore.

Also changes it to not prompt the user for details for permission sets
anymore. Instead, that data is read from a file the user provides.
Permission sets are the portion of the RBAC rule consisting of the
actions, data actions, and scope. The principal is also part of the rule
but the user is prompted for that instead of it being read from a file.
Most plugin users won't need more than one rule because while they may
have multiple levels of scope to work with, they will likely only be
validating one principal. This should be very minimal prompting, with
most data coming from the file.

Example:

```
Note: You must configure at least one rule for plugin configuration.
Note: Collecting input for rule #1
Rule type: 
  > RBAC
Rule name: rule-1
Enter security principal.
Format: Azure GUID
Example: d6df0bba-800d-492f-802e-d04a38c80786
Security principal: cc7f25f8-4ab7-4274-a684-1f5670cd6c60
Note: You must configure at least one permission set for rule.
If you're updating an existing RBAC rule, its permission sets will be replaced.
Permission sets file path: tests/integration/_validator/testcases/data/azurePermissionSets.json
Add additional RBAC rule? [y/N]: No
```

This is intentional:

```
Rule type: 
  > RBAC
```

validatorctl only supports RBAC rules right now, but more rules are
being added to the plugin and they will be added to validatorctl later.
Leaving this here as a placeholder.

---------

Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerGillson TylerGillson Awaiting requested review from TylerGillson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmad-ibra @TylerGillson