Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression 13.5.1: isURL() fails for number urls, e.g. 1234.com #1544

Closed
mbalaam opened this issue Dec 3, 2020 · 1 comment
Closed

Regression 13.5.1: isURL() fails for number urls, e.g. 1234.com #1544

mbalaam opened this issue Dec 3, 2020 · 1 comment
Labels
🐛 bug pr-raised

Comments

@mbalaam
Copy link

mbalaam commented Dec 3, 2020

Describe the bug
Using 13.1.17 we have a test for the url http://1337.net (yes, very much lols) which passed, and as far as I can see appears to be a valid url.

This is now failing on 13.5.1, if I try changing to http://l337.net or http://133t.net then the tests pass.

Additional context
Validator.js version: 13.5.1
Node.js version: v12.18.2
OS platform: macOS
@tux-tn tux-tn mentioned this issue Dec 4, 2020
Merged
2 tasks
profnandaa pushed a commit that referenced this issue Dec 8, 2020
@tux-tn
fix(isFQDN): numeric domain names (#1546)
3358f45 
fixes #1545 #1543 #1544
@profnandaa
Copy link
Member

Fixed in #1546 -- will release this patch as a hotfix due to the regression.

profnandaa added a commit that referenced this issue Dec 10, 2020
@profnandaa
13.5.2
96afe43 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
profnandaa added a commit that referenced this issue Dec 10, 2020
@profnandaa
13.5.2
cff2b76 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
profnandaa added a commit that referenced this issue Dec 10, 2020
@profnandaa
13.5.2
b793beb 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug pr-raised
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@profnandaa @mbalaam