Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isFQDN returns false for a valid FQDN #1545

Closed
niftylettuce opened this issue Dec 4, 2020 · 1 comment · Fixed by #1546
Closed

isFQDN returns false for a valid FQDN #1545

niftylettuce opened this issue Dec 4, 2020 · 1 comment · Fixed by #1546
Labels
🐛 bug pr-raised

Comments

@niftylettuce
Copy link

Describe the bug

Expected result is true but it returns false.

Examples

> require('is-fqdn')('12345.xyz')
true
> require('validator').isFQDN('12345.xyz')
false

Additional context
Validator.js version: Latest
Node.js version: LTS
OS platform: macOS
niftylettuce added a commit to forwardemail/free-email-forwarding that referenced this issue Dec 4, 2020
@niftylettuce
fix: fixed FQDN issue (per <validatorjs/validator.js#1545>)
248a5b9
niftylettuce added a commit to forwardemail/forwardemail.net that referenced this issue Dec 4, 2020
@niftylettuce
fix: fixed FQDN issue (per <validatorjs/validator.js#1545>)
1173c72
@tux-tn tux-tn mentioned this issue Dec 4, 2020
Merged
2 tasks
profnandaa pushed a commit that referenced this issue Dec 8, 2020
@tux-tn
fix(isFQDN): numeric domain names (#1546)
3358f45 
fixes #1545 #1543 #1544
@profnandaa
Copy link
Member

Fixed in #1546 -- will release this patch as a hotfix due to the regression.

profnandaa added a commit that referenced this issue Dec 10, 2020
@profnandaa
13.5.2
96afe43 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
profnandaa added a commit that referenced this issue Dec 10, 2020
@profnandaa
13.5.2
cff2b76 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
profnandaa added a commit that referenced this issue Dec 10, 2020
@profnandaa
13.5.2
b793beb 
- patch fixing #1545 #1543 and #1544
- ref PR #1546 by @tux-tn
titanism pushed a commit to forwardemail/free-email-forwarding that referenced this issue Jun 14, 2022
@niftylettuce
fix: fixed FQDN issue (per <validatorjs/validator.js#1545>)
45da563
titanism pushed a commit to forwardemail/forwardemail.net that referenced this issue Jul 1, 2022
@niftylettuce
fix: fixed FQDN issue (per <validatorjs/validator.js#1545>)
b428b9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug pr-raised
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for isFQDN wth numeric domain names tux-tn/validator.js
2 participants
@profnandaa @niftylettuce