isDate validation is broken after upgrading to validator v13.11.0

[tomaspanek]

Describe the bug

After upgrading to version 13.11.0, the validation of date strings stopped working as expected.

Examples

Here is a demonstration that compares the validation results between v13.11.0 and v13.9.0 Issue demonstration

Additional context
Validator.js version: 13.11.0
Node.js version: 18.17.0
OS platform: macOS

[brunoabude]

Looks like the Date constructor is now using the ISO8601 date format without the time zone offset info, which causes it to be interpreted as UTC+0 and can fail the comparison of .getDate() and the parsed day from the date string (which could be safely assumed to be in local time, i guess?)

To keep the same behaviour as the previous version, T00:00:00 could be concatenated to the isoformat, which will cause it to be interpreted as local time. As demonstrated here

validator.js/src/lib/isDate.js

Line 68 in f074abd

return new Date(`${fullYear}-${dateObj.m}-${dateObj.d}`).getDate() === +dateObj.d;

[tomaspanek]

Thanks, @brunoabude! Just submitted a pull request that would solve the timezone issues as you suggested.

[sacummings91]

Can confirm this was breaking for us too. It was tricky to debug cuz it worked in our CI just fine but was failing locally. Rolling back to 13.9.0 for now to solve the issue until the fix goes in.

[gabdara]

I have the same problem on macOS, seems to work on other platforms though. reverted to 13.9.0 for now.

[Achilles718611]

When are we going to have next release?
Due to this issue, I can't use the latest version.

[brendengerber]

@Achilles718611 Also wondering this, I just downgraded to 13.9.0 and everything is working for me in the meantime

[ThiefMaster]

A bugfix release would be HIGHLY appreciated! :)

[WikiRik]

This should be fixed in v13.12.0 which will be released after #2269 is merged

[profnandaa]

Now released - https://www.npmjs.com/package/validator/v/13.12.0