maintenance: 2405 release #2269

profnandaa · 2023-08-18T12:52:19Z

~~This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".~~

This is being repurposed to the May 2024 release.

13.12.0

New Features / Validators

#2143 isAbaRouting @songyuew

Fixes, New Locales and Enhancements

#2207 isLicensePlate add Pakistani en-PK locale @anasshakil
#2208 isPort fix invalid leading zeros @anasshakil
#2224 isTaxID added Argentina es-AR locale @estefrare
#2257 isDate timezone offset fix @tomaspanek
#2265 isPassportNumber added ZA locale @GMorris-professional
isMobilePhone:
- #2267 added en-MW locale @SimranSiddiqui
- #2140 fix am-AM locale @AlexKrupko
#2271 isPostalAddress fix NL locale @RobinvanderVliet
#2273 isISO4217 add SLE currency @urg
#2278 isStrongPassword fix symbolRegex to include \ @nandavikas
#2279 isVAT fixed KZ locale @MatthieuLemoine
#2285 isAlpha, isAlphanumeric added eo locale @RobinvanderVliet
#2320 isIBAN add Algeria DZ locale @thibault-lr
#2343 isVATimprove AU locale @matthewberryman
#2345 isUUID add support for v7 @ruscon
#2358 isTaxID add Ukraine uk-UA locale @arttiger
#2381 isDate disallow hiphen before year @Sumit-tech-joshi
Doc fixes and others:
- #2276 @meyfa
- #2341 @WikiRik
- #2364 @rubiin
- #2368 @ZhulinskiiDanil
- #2371 @devmanbud
- #2386 @alinaghale88

* Timezone Offset Fix & Parsing with Leading Zeros * `isDate` Timezone Mock Test, Support for NodeJS <8 * `isDate` Unit Test Resiliency Improvement

* Included Regex for South African Passport Number * Corrected Passport validation * Update README.md

* Added the regex and tests for Malawi phone number validation * Added the regex and tests for Malawi phone number validation * Added the regex and tests for Malawi phone number validation

src/lib/isPassportNumber.js

profnandaa · 2023-08-19T09:24:36Z

Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.

rubiin · 2023-08-21T15:08:29Z

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

profnandaa · 2023-08-21T15:15:19Z

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

rubiin · 2023-08-21T15:30:48Z

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator
We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.
The first version can be a simple copy paste.

WikiRik · 2023-09-20T09:13:43Z

@profnandaa any chance we can get this release out soon?

profnandaa · 2023-09-20T09:39:19Z

@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.

WikiRik · 2023-09-20T09:50:06Z

What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)

* chore: add additional testcases to isMailtoURI Line 44 is only partially covered before this change * chore: add additonal const to figure out which part is partial * chore: add testcase for single ? * chore: add another line to find partial coverage * chore: remove default to * chore: combine consts again

rubiin · 2024-03-28T08:36:17Z

I have add LGTM labels to few issues, we can add them to this pipeline

Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>

profnandaa · 2024-04-25T09:38:30Z

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR!   dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR!   peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR!   node_modules/rollup-plugin-babel
npm ERR!     dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.
I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

closes #2344

profnandaa · 2024-04-25T09:43:53Z

Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22

* Update isPassportNumber.js Added the updated Azerbaijan passport validation: See issue: #2274 * Update validators.test.js

* Add Esperanto to alpha.js * Add Esperanto (eo) to README.md * Add tests for Esperanto validation * Fix tests * Update Esperanto tests

* Pakistan vehicles license plate support * Readme and test cases updated * Update README.md

Added isAbaRouting validator, new validator. Check whether a string is ABA routing number for US bank account & cheque ref: https://en.wikipedia.org/wiki/ABA_routing_transit_number

profnandaa · 2024-04-25T10:14:27Z

UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land

Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>

rubiin · 2024-04-27T12:27:29Z

Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status

* chore: Publish to NPM with provenance The release process in this repository is already automated via GitHub Actions, which is a great first step toward creating trust in the supply chain. Recently, NPM has started to support publishing with the `--provenance` flag. This flag creates a link between the GitHub Actions run that created the release and the final artifact on NPM. This linkage further ensures that package installs can be traced back to a specific code revision. For more information on publishing with provenance, please refer to: https://github.blog/2023-04-19-introducing-npm-package-provenance/ * chore: Use Node.js 18 for publishing to support provenance

* Modified symbolRegex in isStrongPassword to include '\' * Modify test to check validity of strong password with \ character

* fix(isVAT): fixed KZ VAT number length check * fix(isVAT): fixed KZ VAT number length test

Co-authored-by: vfarylevych <vfarylevych@primocollect.com.ua>

rubiin · 2024-04-27T15:04:08Z

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR!   dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR!   peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR!   node_modules/rollup-plugin-babel
npm ERR!     dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

#2391 this should fix the problem both on CI and local installs.

profnandaa · 2024-05-02T06:01:45Z

@rubiin @WikiRik @ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.

WikiRik

Looks good to me, thanks for the update and the merger of recent PRs!

profnandaa · 2024-05-09T05:18:31Z

13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0
And once again, thanks @WikiRik and @rubiin for your reviews!

tomaspanek and others added 4 commits August 18, 2023 15:42

fix(isDate): Timezone Offset Fix (#2257)

2c4aede

* Timezone Offset Fix & Parsing with Leading Zeros * `isDate` Timezone Mock Test, Support for NodeJS <8 * `isDate` Unit Test Resiliency Improvement

feat(isTaxId): add tax id for Argentina, es-AR (#2224)

3541b0d

feat(isPassportNumber): added South African, ZA validator (#2265)

6923860

* Included Regex for South African Passport Number * Corrected Passport validation * Update README.md

feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)

b958bd7

* Added the regex and tests for Malawi phone number validation * Added the regex and tests for Malawi phone number validation * Added the regex and tests for Malawi phone number validation

profnandaa added maintenance dont-merge labels Aug 18, 2023

profnandaa requested review from WikiRik, pano9000, rubiin and ezkemboi August 18, 2023 12:52

WikiRik approved these changes Aug 18, 2023

View reviewed changes

src/lib/isPassportNumber.js Show resolved Hide resolved

rubiin approved these changes Aug 18, 2023

View reviewed changes

WikiRik mentioned this pull request Sep 4, 2023

Npm and git master out of sync #2280

Closed

tomaspanek mentioned this pull request Dec 2, 2023

fix(isDate): Timezone Offset Fix #2257

Merged

4 tasks

ZhulinskiiDanil and others added 2 commits March 5, 2024 16:43

fix(docs): misspelling of Mailto (#2368)

332b501

fix(docs): fixed typo in README.md (#2371)

31c88cf

Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>

feat(isUUID): support uuid v7 (#2345)

6d5c52a

closes #2344

profnandaa changed the title ~~maintenance: post 2308 release~~ maintenance: 2404 release Apr 25, 2024

fix(isPassportNumber): fix regex Azerbaijan (#2284)

752bd09

* Update isPassportNumber.js Added the updated Azerbaijan passport validation: See issue: #2274 * Update validators.test.js

RobinvanderVliet and others added 6 commits April 25, 2024 12:54

feat(isAlpha, isAlphanumeric): add Esperanto (eo) locale (#2285)

0a100fe

* Add Esperanto to alpha.js * Add Esperanto (eo) to README.md * Add tests for Esperanto validation * Fix tests * Update Esperanto tests

fix(isPostalCode): improve Dutch postal code regex (#2271)

edb6b1c

fix(isPort): Invalid leading zeros (#2208)

b34a335

feat(isLicensePlate): Support for Pakistani vehicles (#2207)

32b174e

* Pakistan vehicles license plate support * Readme and test cases updated * Update README.md

feat: added isAbaRouting validator (#2143)

19f11cf

Added isAbaRouting validator, new validator. Check whether a string is ABA routing number for US bank account & cheque ref: https://en.wikipedia.org/wiki/ABA_routing_transit_number

fix(isMobilePhone): fixed validation for am-AM (#2140)

6b3f62d

rubiin and others added 2 commits April 25, 2024 13:16

ci: add latest node versions (#2364)

817e56e

Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>

fix(isPassport): added tests for ZA Passport Number (#2270)

72c8dc1

ezkemboi approved these changes Apr 27, 2024

View reviewed changes

urg and others added 3 commits April 27, 2024 17:03

fix: add SLE to the isISO4217 validator (#2273)

5677f91

fix: symbolRegex in isStrongPassword to include '\' (#2278)

8a40349

* Modified symbolRegex in isStrongPassword to include '\' * Modify test to check validity of strong password with \ character

ezkemboi approved these changes Apr 27, 2024

View reviewed changes

MatthieuLemoine and others added 6 commits April 27, 2024 17:07

fix(isVAT): fixed KZ VAT number length check (#2279)

11ac6a4

* fix(isVAT): fixed KZ VAT number length check * fix(isVAT): fixed KZ VAT number length test

feat(isIBAN): add Algeria locale (#2320)

d8c93d2

docs: move contributing guidelines to CONTRIBUTING.md (#2386)

eacccaf

fix(isDate): hyphen before year is not allowed (#2381)

0836777

feat(isTaxID): added TaxID for Ukraine uk-UA (#2358)

43a0f09

Co-authored-by: vfarylevych <vfarylevych@primocollect.com.ua>

fix(isVAT): improved ABN (AU VAT) validation (#2343)

83d6ffd

profnandaa changed the title ~~maintenance: 2404 release~~ maintenance: 2405 release May 2, 2024

WikiRik approved these changes May 2, 2024

View reviewed changes

rubiin approved these changes May 2, 2024

View reviewed changes

WikiRik mentioned this pull request May 7, 2024

isDate validation is broken after upgrading to validator v13.11.0 #2256

Closed

13.12.0

cd4e7bf

profnandaa closed this May 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

maintenance: 2405 release #2269

maintenance: 2405 release #2269

profnandaa commented Aug 18, 2023 •

edited

Loading

profnandaa commented Aug 19, 2023

rubiin commented Aug 21, 2023 •

edited

Loading

profnandaa commented Aug 21, 2023

rubiin commented Aug 21, 2023 •

edited

Loading

WikiRik commented Sep 20, 2023

profnandaa commented Sep 20, 2023

WikiRik commented Sep 20, 2023

rubiin commented Mar 28, 2024

profnandaa commented Apr 25, 2024

profnandaa commented Apr 25, 2024

profnandaa commented Apr 25, 2024

rubiin commented Apr 27, 2024

rubiin commented Apr 27, 2024

profnandaa commented May 2, 2024

WikiRik left a comment

profnandaa commented May 9, 2024

maintenance: 2405 release #2269

maintenance: 2405 release #2269

Conversation

profnandaa commented Aug 18, 2023 • edited Loading

13.12.0

New Features / Validators

Fixes, New Locales and Enhancements

profnandaa commented Aug 19, 2023

rubiin commented Aug 21, 2023 • edited Loading

profnandaa commented Aug 21, 2023

rubiin commented Aug 21, 2023 • edited Loading

WikiRik commented Sep 20, 2023

profnandaa commented Sep 20, 2023

WikiRik commented Sep 20, 2023

rubiin commented Mar 28, 2024

profnandaa commented Apr 25, 2024

profnandaa commented Apr 25, 2024

profnandaa commented Apr 25, 2024

rubiin commented Apr 27, 2024

rubiin commented Apr 27, 2024

profnandaa commented May 2, 2024

WikiRik left a comment

Choose a reason for hiding this comment

profnandaa commented May 9, 2024

profnandaa commented Aug 18, 2023 •

edited

Loading

rubiin commented Aug 21, 2023 •

edited

Loading

rubiin commented Aug 21, 2023 •

edited

Loading