Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified symbolRegex in isStrongPassword to include '\' #2278

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

nandavikas
Copy link
Contributor

@nandavikas nandavikas commented Aug 29, 2023

isStrongPassword - Bug fix

I modified the special character regex a little bit to add validation for '\' character. I worked on this based on an issue in the repository

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b958bd7) 99.95% compared to head (8c06778) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2278   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2454     2454           
  Branches      619      619           
=======================================
  Hits         2453     2453           
  Partials        1        1           
Files Changed Coverage Δ
src/lib/isStrongPassword.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WikiRik
Copy link
Member

WikiRik commented Aug 29, 2023

Thanks for the PR! Don't forget to add additional tests before we can review this

Copy link

@manojmula manojmula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are working and changes are legit.

@profnandaa profnandaa merged commit 8a40349 into validatorjs:master Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants