Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Union Pay cards too #536

Closed
wants to merge 1 commit into from
Closed

Validate Union Pay cards too #536

wants to merge 1 commit into from

Conversation

dhAlcojor
Copy link
Contributor

@dhAlcojor dhAlcojor commented May 31, 2016 •
edited by chriso
Loading

Update creditCard regular expression so it can validate Union Pay credit cards, that start with a '62'.

This fixes #535.

@dhAlcojor
Validate Union Pay cards too
768282d 
Update creditCard regular expression so it can validate Union Pay credit cards, that start with a '62'.
@coveralls
Copy link

coveralls commented May 31, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.091% when pulling 768282d on dhAlcojor:patch-1 into a3bd0fd on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Jun 1, 2016

Can you add some tests?

@dhAlcojor
Copy link
Contributor Author

Yes, I will add some tests as soon as I can.

@chriso
Copy link
Collaborator

chriso commented Jun 5, 2016

See #539.

@chriso chriso closed this Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Union Pay credit cards are always invalid
3 participants
@dhAlcojor @coveralls @chriso