-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #535 and add test cases #539
Conversation
A few other places validate as follows:
Can you fix the regex? |
In this document (https://www.six-payment-services.com/dam/downloads/datasheets/110004302_DS_SecurityFeatures_UnionPay_INT_EN_opt.pdf) it says that Union Pay credit cards start with a 62 and have 16 digits. But it's not clear (to me, at least), what happens with Union Pay debit cards because it says that they have 13 - 19 digits and that some debit cards can start with 3, 4, 5 or 9. This sounds a little crazy, so I'll implement the regex for Union Pay credit cards. |
|
The test failure appears unrelated. |
Yeah, my edit didn't seem capable of breaking anything... |
This time I edited the right file (^^U) and added some test cases for Union Pay credit cards.
This fixes #535.