Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default pidfile #321

Closed
Tracked by #25
zuiderkwast opened this issue Apr 15, 2024 · 1 comment · Fixed by #378
Closed
Tracked by #25

Change default pidfile #321

zuiderkwast opened this issue Apr 15, 2024 · 1 comment · Fixed by #378
Labels
breaking-change Indicates a possible backwards incompatible change rebranding Valkey is not Redis release-notes This issue should get a line item in the release notes

Comments

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Apr 15, 2024 •
edited
Loading

The default pidfile is controlled by this define:

server.h:#define CONFIG_DEFAULT_PID_FILE "/var/run/redis.pid"

The comment in valkey.conf (describing what the default is) needs to match that.

Changing it to valkey.pid is a breaking change, so we'll do it in the next major version.
@zuiderkwast zuiderkwast mentioned this issue Apr 15, 2024
Open
18 tasks
@zuiderkwast zuiderkwast added release-notes This issue should get a line item in the release notes rebranding Valkey is not Redis breaking-change Indicates a possible backwards incompatible change labels Apr 15, 2024
@zuiderkwast zuiderkwast mentioned this issue Apr 15, 2024
Merged
@9bany 9bany mentioned this issue Apr 17, 2024
Closed
@zuiderkwast zuiderkwast moved this to In Progress in Valkey 8.0 Apr 17, 2024
@zuiderkwast zuiderkwast mentioned this issue Jun 11, 2024
Merged
@zuiderkwast
Copy link
Contributor Author

Fixed in #378

@github-project-automation github-project-automation bot moved this from In Progress to Done in Valkey 8.0 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Indicates a possible backwards incompatible change rebranding Valkey is not Redis release-notes This issue should get a line item in the release notes
Projects
Valkey 8.0
Status: Done
Milestone
No milestone
1 participant
@zuiderkwast