Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: rename redis.pid to valkey.pid #330

Closed
wants to merge 1 commit into from
Closed

Draft: rename redis.pid to valkey.pid #330

wants to merge 1 commit into from

Conversation

9bany
Copy link
Contributor

@9bany 9bany commented Apr 17, 2024

fixes: #321

@9bany
rename redis.pid to valkey.pid
af25bfd 
Signed-off-by: 0del <bany.y0599@gmail.com>
zuiderkwast
zuiderkwast requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just one thing missing. It is mentioned in the issue:

"The comment in valkey.conf (describing what the default is) needs to match that."

Also please write a real description in the PR, instead of only a link to the issue. We use the description as the commit message when we merge.

@zuiderkwast
Copy link
Contributor

The PR title is not very correct. It's a changed default filename. (The file is created when the server starts and removed when the server exits. It is not renamed in the file system like mv does.)

@zuiderkwast zuiderkwast added rebranding Valkey is not Redis breaking-change Indicates a possible backwards incompatible change release-notes This issue should get a line item in the release notes labels Apr 17, 2024
@9bany 9bany changed the title rename redis.pid to valkey.pid DRAFT: rename redis.pid to valkey.pid Apr 17, 2024
@9bany 9bany changed the title DRAFT: rename redis.pid to valkey.pid Draft: rename redis.pid to valkey.pid Apr 17, 2024
@zuiderkwast
Copy link
Contributor

This line needs to be updated: https://github.com/valkey-io/valkey/blob/unstable/valkey.conf#L332

@zuiderkwast
Copy link
Contributor

Superseeded by #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast requested changes

Assignees
No one assigned
Labels
breaking-change Indicates a possible backwards incompatible change rebranding Valkey is not Redis release-notes This issue should get a line item in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default pidfile
2 participants
@9bany @zuiderkwast