Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default pidfile from redis.pid to valkey.pid #378

Merged

Conversation

Shivshankar-Reddy
Copy link
Contributor

@Shivshankar-Reddy Shivshankar-Reddy commented Apr 25, 2024

Changes the default value for the pidfile config.

The template config file valkey.conf already contains pidfile /var/run/valkey_6379.pid. This is not a default. The default is what you get when you start valkey without config.

Tests suites config pidfile changed to valkey accordingly.

Fixes #321

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (52f9291) to head (db63a87).
Report is 10 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable     #378   +/-   ##
=========================================
  Coverage     68.40%   68.40%           
=========================================
  Files           108      108           
  Lines         61562    61562           
=========================================
  Hits          42109    42109           
  Misses        19453    19453           

see 10 files with indirect coverage changes

@Shivshankar-Reddy
Copy link
Contributor Author

@zuiderkwast, Can you check this PR when you get some time?

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

pidfile /var/run/valkey_6379.pid was already written in the template config file valkey.conf. This is not a default. It is a value you get if you use the template config as is. The default is what you get when you start without a config.

@zuiderkwast zuiderkwast changed the title Rename pid file name redis.pid to valkey.pid Change default pidfile from redis.pid to valkey.pid Apr 30, 2024
@zuiderkwast zuiderkwast added release-notes This issue should get a line item in the release notes rebranding Valkey is not Redis labels Apr 30, 2024
@zuiderkwast zuiderkwast merged commit 0cb9765 into valkey-io:unstable Apr 30, 2024
17 checks passed
@Shivshankar-Reddy Shivshankar-Reddy deleted the change-pid-file-name branch October 7, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebranding Valkey is not Redis release-notes This issue should get a line item in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default pidfile
2 participants