Removing Redis from internal lua function names and comments #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edis from internal function names. * Fixed a bug where 'server *' invocation from lua debugger was not working. * Functions in lua c files lack of documentation. Adding some documentation in this commit. * I removed Redis from function names in eval.c and script_lua.c files. I did not touch log messages in this commit. I also did not touch references to "RedisProtocol". Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
* Fixed comments to be 120 line length. * Aliased error handler function. * Renamed REDIS_LRAND... variable to SERVER... * I did not rename RedisProtocol as it refers to the RESP protocol. Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
zuiderkwast
changed the title
Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1102 +/- ##
============================================
- Coverage 70.62% 70.60% -0.02%
============================================
Files 114 114
Lines 61695 61699 +4
============================================
- Hits 43571 43562 -9
- Misses 18124 18137 +13
|
Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
|
Fixed all problems with the build. Next build will succeed. This is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to rebase on top of recent changes, so creating this new PR. This has changes to handle comments on previous PR #288.