Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Redis from internal lua function names and comments #1102

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Removing Redis from internal lua function names and comments #1102

merged 8 commits into from
Oct 4, 2024

Commits on Oct 1, 2024

  1. Fixed a bug in lua debugger for 'server *' invocations and Removing R… 

    …edis from internal function names.

* Fixed a bug where 'server *' invocation from lua debugger was not working.
* Functions in lua c files lack of documentation. Adding some documentation in this commit.
* I removed Redis from function names in eval.c and script_lua.c files. I did not touch log messages in this commit. I also did not touch references to "RedisProtocol".

Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d0691de View commit details
    Browse the repository at this point in the history

  2. Fixes based on PR feedback. 

    * Fixed comments to be 120 line length.
* Aliased error handler function.
* Renamed REDIS_LRAND... variable to SERVER...
* I did not rename RedisProtocol as it refers to the RESP protocol.

Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f46f084 View commit details
    Browse the repository at this point in the history

  3. Fixing a merge conflict 

    Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f6887da View commit details
    Browse the repository at this point in the history

  4. Formatting the code as per suggestions from the build process. 

    Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1c7b407 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fixing "customer message" typo 

    Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c1c1695 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Resolving the conflict to keep Resp in the function names. 

    Signed-off-by: Parth Patel <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3a9f3c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Update src/script_lua.c to add __redis__err__handler as backup in the… 

    … server_api_allo_list

Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Parth <661497+parthpatel@users.noreply.github.com>
    @parthpatel @madolson
    parthpatel and madolson authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a5a9fe8 View commit details
    Browse the repository at this point in the history

  2. Fixing a formatting issue due to extra space before a comment. 

    Signed-off-by: Parth <661497+parthpatel@users.noreply.github.com>
    @parthpatel
    parthpatel committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2ddd7e6 View commit details
    Browse the repository at this point in the history