Log unexpected $ENDOFF responses in dual channel replication #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried to test a dual channel replication but forgot to add +copy for my replication user. As a result replica entered silent cycle like this: ``` * Connecting to PRIMARY 127.0.0.1:6379 * PRIMARY <-> REPLICA sync started * Non blocking connect for SYNC fired the event. * Primary replied to PING, replication can continue... * Trying a partial resynchronization (request ...) * PSYNC is not possible, initialize RDB channel. * Aborting dual channel sync ``` And primary got endless cycle like this: ``` * Replica 127.0.0.1:6380 asks for synchronization * Partial resynchronization not accepted: Replication ID mismatch (Replica asked for '...', my replication IDs are '...' and '...') * Replica 127.0.0.1:6380 is capable of dual channel synchronization, and partial sync isn't possible. Full sync will continue with dedicated RDB channel. ``` There was no way to understand that replication user is missing +copy acl on notice log level. With this one-line change we get a warning message in our replica log. --------- Signed-off-by: secwall <secwall@yandex-team.ru>
|
@secwall Can I ask what your use case was to manually be setting up the dual channel? |
I've been trying to test how the new features in version 8.0 work in our environment. |
madolson
approved these changes
Aug 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #839 +/- ##
============================================
- Coverage 70.38% 70.36% -0.02%
============================================
Files 112 112
Lines 61462 61463 +1
============================================
- Hits 43261 43250 -11
- Misses 18201 18213 +12
|
madolson
added
the
release-notes
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 21, 2024
…io#839) I've tried to test a dual channel replication but forgot to add +sync for my replication user. As a result replica entered silent cycle like this: ``` * Connecting to PRIMARY 127.0.0.1:6379 * PRIMARY <-> REPLICA sync started * Non blocking connect for SYNC fired the event. * Primary replied to PING, replication can continue... * Trying a partial resynchronization (request ...) * PSYNC is not possible, initialize RDB channel. * Aborting dual channel sync ``` And primary got endless cycle like this: ``` * Replica 127.0.0.1:6380 asks for synchronization * Partial resynchronization not accepted: Replication ID mismatch (Replica asked for '...', my replication IDs are '...' and '...') * Replica 127.0.0.1:6380 is capable of dual channel synchronization, and partial sync isn't possible. Full sync will continue with dedicated RDB channel. ``` There was no way to understand that replication user is missing +sync acl on notice log level. With this one-line change we get a warning message in our replica log. --------- Signed-off-by: secwall <secwall@yandex-team.ru> Signed-off-by: mwish <maplewish117@gmail.com>
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 22, 2024
…io#839) I've tried to test a dual channel replication but forgot to add +sync for my replication user. As a result replica entered silent cycle like this: ``` * Connecting to PRIMARY 127.0.0.1:6379 * PRIMARY <-> REPLICA sync started * Non blocking connect for SYNC fired the event. * Primary replied to PING, replication can continue... * Trying a partial resynchronization (request ...) * PSYNC is not possible, initialize RDB channel. * Aborting dual channel sync ``` And primary got endless cycle like this: ``` * Replica 127.0.0.1:6380 asks for synchronization * Partial resynchronization not accepted: Replication ID mismatch (Replica asked for '...', my replication IDs are '...' and '...') * Replica 127.0.0.1:6380 is capable of dual channel synchronization, and partial sync isn't possible. Full sync will continue with dedicated RDB channel. ``` There was no way to understand that replication user is missing +sync acl on notice log level. With this one-line change we get a warning message in our replica log. --------- Signed-off-by: secwall <secwall@yandex-team.ru> Signed-off-by: mwish <maplewish117@gmail.com>
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
I've tried to test a dual channel replication but forgot to add +sync for my replication user. As a result replica entered silent cycle like this: ``` * Connecting to PRIMARY 127.0.0.1:6379 * PRIMARY <-> REPLICA sync started * Non blocking connect for SYNC fired the event. * Primary replied to PING, replication can continue... * Trying a partial resynchronization (request ...) * PSYNC is not possible, initialize RDB channel. * Aborting dual channel sync ``` And primary got endless cycle like this: ``` * Replica 127.0.0.1:6380 asks for synchronization * Partial resynchronization not accepted: Replication ID mismatch (Replica asked for '...', my replication IDs are '...' and '...') * Replica 127.0.0.1:6380 is capable of dual channel synchronization, and partial sync isn't possible. Full sync will continue with dedicated RDB channel. ``` There was no way to understand that replication user is missing +sync acl on notice log level. With this one-line change we get a warning message in our replica log. --------- Signed-off-by: secwall <secwall@yandex-team.ru>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
I've tried to test a dual channel replication but forgot to add +sync for my replication user. As a result replica entered silent cycle like this: ``` * Connecting to PRIMARY 127.0.0.1:6379 * PRIMARY <-> REPLICA sync started * Non blocking connect for SYNC fired the event. * Primary replied to PING, replication can continue... * Trying a partial resynchronization (request ...) * PSYNC is not possible, initialize RDB channel. * Aborting dual channel sync ``` And primary got endless cycle like this: ``` * Replica 127.0.0.1:6380 asks for synchronization * Partial resynchronization not accepted: Replication ID mismatch (Replica asked for '...', my replication IDs are '...' and '...') * Replica 127.0.0.1:6380 is capable of dual channel synchronization, and partial sync isn't possible. Full sync will continue with dedicated RDB channel. ``` There was no way to understand that replication user is missing +sync acl on notice log level. With this one-line change we get a warning message in our replica log. --------- Signed-off-by: secwall <secwall@yandex-team.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to test a dual channel replication but forgot to add +sync for my replication user. As a result replica entered silent cycle like this:
And primary got endless cycle like this:
There was no way to understand that replication user is missing +sync acl on notice log level. With this one-line change we get a warning message in our replica log.
Signed-off-by: secwall secwall@yandex-team.ru