Commits on Jul 29, 2024

1. Log unexpected $ENDOFF responses in dual channel replication …

   I've tried to test a dual channel replication but forgot to add +copy
   for my replication user. As a result replica entered silent cycle like
   this:
   ```
   * Connecting to PRIMARY 127.0.0.1:6379
   * PRIMARY <-> REPLICA sync started
   * Non blocking connect for SYNC fired the event.
   * Primary replied to PING, replication can continue...
   * Trying a partial resynchronization (request ...)
   * PSYNC is not possible, initialize RDB channel.
   * Aborting dual channel sync
   ```
   
   And primary got endless cycle like this:
   ```
   * Replica 127.0.0.1:6380 asks for synchronization
   * Partial resynchronization not accepted: Replication ID mismatch (Replica asked for '...', my replication IDs are '...' and '...')
   * Replica 127.0.0.1:6380 is capable of dual channel synchronization, and partial sync isn't possible. Full sync will continue with dedicated RDB channel.
   ```
   
   There was no way to understand that replication user is missing +copy acl on notice log level.
   With this one-line change we get a warning message in our replica log.
   
   ---------
   
   Signed-off-by: secwall <secwall@yandex-team.ru>

   

   secwall committed Jul 29, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ab13533
   • Browse repository at this point

   Copy the full SHA

   ab13533 View commit details

   Browse the repository at this point in the history