Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buttons): btnRadio does not work with reactive forms in versions >1.7.1 #2581

Closed
ds82 opened this issue Sep 4, 2017 · 7 comments
Closed

fix(buttons): btnRadio does not work with reactive forms in versions >1.7.1 #2581

ds82 opened this issue Sep 4, 2017 · 7 comments
Assignees
@IlyaSurmay
Labels
comp(buttons) effort1: easy (hours) issue prio: medium
Milestone
v2.0.0

Comments

@ds82
Copy link

ds82 commented Sep 4, 2017

Using btnRadio & reactive forms I can only switch the value of the radio button-group once.

Tested with ngx-boostrap@1.9.1 & angular@4.3.6:
https://stackblitz.com/edit/angular-eck1fy
(You can switch the radio from false to true, but not back)

The bug does not occur in ngx-bootstrap@1.7.1.
Same demo as above with v1.7.1:
https://stackblitz.com/edit/angular-ycuxdq
@valorkin
Copy link
Member

valorkin commented Sep 5, 2017

Interesting, cuz works on demo page
http://valor-software.com/ngx-bootstrap/#/buttons#radio

@ds82
Copy link
Author

ds82 commented Sep 5, 2017

The demo kind of confuses me .. the "reactive form radio button demo" does not use radio buttons; it's more kind of a checkbox button demo (it indeed uses btnCheckbox and not btnRadio).

@verjik
Copy link

verjik commented Sep 5, 2017

@valorkin, there is only reactive-checkbox example, reactive-radio is missing

@valorkin
Copy link
Member

valorkin commented Sep 5, 2017

lol, true

@BenjD90
Copy link

BenjD90 commented Sep 25, 2017

Here two Plunkers that show this issue with btnRadio :

In ngx-boostrap@1.9.3 : http://plnkr.co/edit/t3tYCPC2Qag0GRQzHJLr
In ngx-bootstrap@1.7.1 : http://plnkr.co/edit/QkxYbbbfbwO07GwcmkdN

I hope one can find a fix or a workaround quickly :)

@dave0688
Copy link

A Fix for that would be very nice!

@valorkin valorkin added this to the v2.0.0 milestone Nov 23, 2017
@CloudNiner CloudNiner mentioned this issue Dec 22, 2017
Merged
CloudNiner pushed a commit to azavea/temperate that referenced this issue Dec 22, 2017
Directly update freq/intensity form controls
75f13a1 
The ngx-bootstrap button group btnRadio directive
is busted for reactive forms, so we just implement
directly with events for now instead:

valor-software/ngx-bootstrap#2581
CloudNiner pushed a commit to azavea/temperate that referenced this issue Dec 22, 2017
Directly update freq/intensity form controls
e71a31e 
The ngx-bootstrap button group btnRadio directive
is busted for reactive forms, so we just implement
directly with events for now instead:

valor-software/ngx-bootstrap#2581
@AndreyYevtukhov
Copy link

still doesn't works(
checked in 2.0.0-rc.0

@IlyaSurmay IlyaSurmay mentioned this issue Jan 3, 2018
Merged
4 tasks
@ghost ghost assigned IlyaSurmay Jan 3, 2018
@ghost ghost added the in progress label Jan 3, 2018
@YevheniiaMazur YevheniiaMazur changed the title btnRadio does not work with reactive forms in versions >1.7.1 fix(buttons): btnRadio does not work with reactive forms in versions >1.7.1 Jan 15, 2018
@artolshansky artolshansky mentioned this issue Jan 15, 2018
Closed
24 tasks
valorkin pushed a commit that referenced this issue Jan 18, 2018
@IlyaSurmay @valorkin
fix(buttons): fix radio btns for reactive forms, add radio reactive d…
b2b8bdc 
…emo (#3384)

fixes #2581
@ghost ghost removed the in progress label Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaSurmay IlyaSurmay

Labels
comp(buttons) effort1: easy (hours) issue prio: medium
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
8 participants
@ds82 @valorkin @verjik @BenjD90 @AndreyYevtukhov @IlyaSurmay @dave0688 @YevheniiaMazur