fix(buttons): fix radio btns for reactive forms, add radio reactive demo #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## development #3384 +/- ##
==============================================
- Coverage 72.39% 72.3% -0.09%
==============================================
Files 249 250 +1
Lines 8039 8078 +39
Branches 1527 1533 +6
==============================================
+ Hits 5820 5841 +21
- Misses 1795 1809 +14
- Partials 424 428 +4
Continue to review full report at Codecov.
|
valorkin
requested changes
Jan 5, 2018
| selector: '[btnRadioGroup]', | ||
| providers: [RADIO_CONTROL_VALUE_ACCESSOR] | ||
| }) | ||
| export class ButtonRadioGroupDirective implements ControlValueAccessor { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
|
||
| /** Radio button value, will be set to `ngModel` */ | ||
| @Input() btnRadio: any; | ||
| /** If `true` — radio button can be unchecked */ | ||
| @Input() uncheckable: boolean; | ||
| /** Current value of radio component or group */ | ||
| @Input() value: any; | ||
| @Input() get value(): any { | ||
| return this.group ? this.group.value : this._value; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| return; | ||
| } | ||
| if (this.group) { | ||
| this.group.onTouched(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IlyaSurmay
force-pushed
the
fix-radio-reactive
branch
from
f3f2bd3
to
1ba14cb
Compare
valorkin
approved these changes
Jan 12, 2018
valorkin
approved these changes
Jan 18, 2018
|
Tested, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2581
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.