refactor(earn): connect pool details to deposit screen #5858
Conversation
| @@ -98,7 +98,7 @@ export async function prepareSupplyTransactions({ | |||
| feeCurrencies, | |||
| baseTransactions, | |||
| spendToken: token, | |||
| spendTokenAmount: new BigNumber(amount), | |||
| spendTokenAmount: new BigNumber(amount).shiftedBy(token.decimals), | |||
There was a problem hiding this comment.
this is only an issue if the spendToken is also the gas currency. For aave, this can never be the case so there was no user impact
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5858 +/- ##
========================================
Coverage 87.50% 87.51%
========================================
Files 726 726
Lines 31064 31066 +2
Branches 5212 5501 +289
========================================
+ Hits 27183 27186 +3
+ Misses 3837 3836 -1
Partials 44 44
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -268,7 +268,7 @@ export async function tryEstimateTransactions( | |||
| * | |||
| * @param feeCurrencies | |||
| * @param spendToken | |||
| * @param spendTokenAmount | |||
| * @param spendTokenAmount BigNumber in smallest unit | |||
There was a problem hiding this comment.
what exactly does smallest unit mean?
There was a problem hiding this comment.
the smallest unit of the token (e.g., 1ETH => 1e18, 1 usdc => 1e6). I believe we use this term in a few places in the wallet
Description
Also fixes a small bug in earn prepare transactions with amount units.
Test plan
CI
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: