-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(earn): connect pool details to deposit screen #5858
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -268,7 +268,7 @@ export async function tryEstimateTransactions( | |
* | ||
* @param feeCurrencies | ||
* @param spendToken | ||
* @param spendTokenAmount | ||
* @param spendTokenAmount BigNumber in smallest unit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what exactly does smallest unit mean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the smallest unit of the token (e.g., 1ETH => 1e18, 1 usdc => 1e6). I believe we use this term in a few places in the wallet |
||
* @param decreasedAmountGasFeeMultiplier | ||
* @param baseTransactions | ||
* @param throwOnSpendTokenAmountExceedsBalance | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only an issue if the spendToken is also the gas currency. For aave, this can never be the case so there was no user impact