refactor: move deep link prefix to .env file #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6008 +/- ##
==========================================
+ Coverage 88.61% 88.62% +0.01%
==========================================
Files 728 726 -2
Lines 30546 30466 -80
Branches 5224 5216 -8
==========================================
- Hits 27068 27001 -67
+ Misses 3435 3422 -13
Partials 43 43
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeanregisser
approved these changes
Sep 16, 2024
ios/celo/AppDelegate.mm
Outdated
| @@ -77,8 +77,9 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
| [[CleverTapReactManager sharedInstance] applicationDidLaunchWithOptions:launchOptions]; | |||
|
|
|||
| NSString *env = [RNCConfig envFor:@"FIREBASE_ENABLED"]; | |||
| NSString *deepLinkPrefix = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"DEEP_LINK_PREFIX"]; | |||
There was a problem hiding this comment.
Suggested change
| NSString *deepLinkPrefix = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"DEEP_LINK_PREFIX"]; | |
| NSString *deepLinkPrefix = [RNCConfig envFor:@"DEEP_LINK_PREFIX"]; |
.env.alfajores
Outdated
| @@ -12,3 +12,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.alfajores.plist | |||
| SENTRY_ENABLED=true | |||
| AUTH0_DOMAIN=auth.alfajores.valora.xyz | |||
| ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet | |||
| DEEP_LINK_PREFIX=celo | |||
There was a problem hiding this comment.
What do you think of naming it DEEP_LINK_URL_SCHEME?
It better represents what it is and more closely follows what iOS and Android use for this.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to making the MS runtime native folders brand agnostic. This PR:
srcfolderTest plan
CI passes - we have deep link tests there.
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: