refactor: move deep link prefix to .env file

.env.alfajores

@@ -12,3 +12,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.alfajores.plist
 SENTRY_ENABLED=true
 AUTH0_DOMAIN=auth.alfajores.valora.xyz
 ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet
+DEEP_LINK_PREFIX=celo

.env.alfajoresdev

@@ -14,3 +14,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.alfajoresdev.plist
 SENTRY_ENABLED=false
 AUTH0_DOMAIN=auth.alfajores.valora.xyz
 ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet
+DEEP_LINK_PREFIX=celo

.env.alfajoresnightly

@@ -12,3 +12,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.alfajoresnightly.plist
 SENTRY_ENABLED=true
 AUTH0_DOMAIN=auth.alfajores.valora.xyz
 ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet
+DEEP_LINK_PREFIX=celo

.env.example

@@ -24,3 +24,4 @@ ENABLED_QUICK_ACTIONS=Send,Receive,Add,Swap,Withdraw
 # See all possible feature values in ToggleableOnboardingFeatures.
 # This example enabled all features except PhoneVerification
 ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet
+DEEP_LINK_PREFIX=celo

.env.mainnet

@@ -12,3 +12,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.mainnet.plist
 SENTRY_ENABLED=true
 AUTH0_DOMAIN=auth.valora.xyz
 ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet
+DEEP_LINK_PREFIX=celo

.env.mainnetdev

@@ -14,3 +14,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.mainnetdev.plist
 SENTRY_ENABLED=false
 AUTH0_DOMAIN=auth.valora.xyz
 ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet
+DEEP_LINK_PREFIX=celo

.env.mainnetnightly

@@ -12,3 +12,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.mainnetnightly.plist
 SENTRY_ENABLED=true
 AUTH0_DOMAIN=auth.valora.xyz
 ONBOARDING_FEATURES_ENABLED=CloudBackupSetup,CloudBackupRestore,CloudBackupInOnboarding,EnableBiometry,ProtectWallet
+DEEP_LINK_PREFIX=celo

.env.test

@@ -10,3 +10,4 @@ IOS_GOOGLE_SERVICE_PLIST=GoogleService-Info.alfajores.plist
 SENTRY_ENABLED=false
 AUTH0_DOMAIN=auth.alfajores.valora.xyz
 ONBOARDING_FEATURES_ENABLED=EnableBiometry,ProtectWallet,PhoneVerification
+DEEP_LINK_PREFIX=celo

__mocks__/react-native-config.ts

@@ -4,4 +4,5 @@ export default {
   SHOW_TESTNET_BANNER: 'true',
   DEFAULT_TESTNET: 'alfajores',
   AUTH0_DOMAIN: 'auth0.com',
+  DEEP_LINK_PREFIX: 'celo',
 }

android/app/build.gradle

@@ -156,6 +156,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         resValue "string", "app_name", project.env.get("APP_DISPLAY_NAME")
         resValue "string", "build_config_package", "org.celo.mobile"
+        resValue "string", "deep_link_prefix", project.env.get("DEEP_LINK_PREFIX")
         missingDimensionStrategy 'react-native-camera', 'general'
         vectorDrawables.useSupportLibrary = true
         resValue "bool", "is_profiling_build", System.getenv("IS_PROFILING_BUILD") ?: "false"

android/app/src/main/AndroidManifest.xml

@@ -24,7 +24,7 @@
         <action android:name="android.intent.action.VIEW" />
         <category android:name="android.intent.category.DEFAULT" />
         <category android:name="android.intent.category.BROWSABLE" />
-        <data android:scheme="celo" android:host="wallet" />
+        <data android:scheme="@string/deep_link_prefix" android:host="wallet" />
       </intent-filter>
       <intent-filter>
         <action android:name="android.intent.action.VIEW" />

ios/celo/AppDelegate.mm

@@ -77,8 +77,9 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
   [[CleverTapReactManager sharedInstance] applicationDidLaunchWithOptions:launchOptions];
 
   NSString *env = [RNCConfig envFor:@"FIREBASE_ENABLED"];
+  NSString *deepLinkPrefix = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"DEEP_LINK_PREFIX"];
   if (env.boolValue) {
-    [FIROptions defaultOptions].deepLinkURLScheme = @"celo";
+    [FIROptions defaultOptions].deepLinkURLScheme = deepLinkPrefix;
     [FIRApp configure];
   }
 

ios/celo/Info.plist

@@ -33,7 +33,7 @@
 			<string></string>
 			<key>CFBundleURLSchemes</key>
 			<array>
-				<string>celo</string>
+				<string>$(DEEP_LINK_PREFIX)</string>
 			</array>
 		</dict>
 		<dict>

src/app/reducers.ts

@@ -2,14 +2,14 @@ import { Platform } from 'react-native'
 import { BIOMETRY_TYPE } from 'react-native-keychain'
 import { Actions, ActionTypes, AppState, MultichainBetaStatus } from 'src/app/actions'
 import { CeloNewsConfig } from 'src/celoNews/types'
-import { DEEPLINK_PREFIX } from 'src/config'
+import { DEEP_LINK_PREFIX } from 'src/config'
 import { REMOTE_CONFIG_VALUES_DEFAULTS } from 'src/firebase/remoteConfigValuesDefaults'
 import { Screens } from 'src/navigator/Screens'
 import { getRehydratePayload, REHYDRATE, RehydrateAction } from 'src/redux/persist-helper'
 
 const PERSISTED_DEEP_LINKS = [
   'https://valoraapp.com/share',
-  `${DEEPLINK_PREFIX}://wallet/jumpstart`,
+  `${DEEP_LINK_PREFIX}://wallet/jumpstart`,
 ]
 
 interface State {

src/app/saga.test.ts

@@ -29,7 +29,7 @@ import {
   inAppReviewLastInteractionTimestampSelector,
   sentryNetworkErrorsSelector,
 } from 'src/app/selectors'
-import { DEEPLINK_PREFIX } from 'src/config'
+import { DEEP_LINK_PREFIX } from 'src/config'
 import { activeDappSelector } from 'src/dapps/selectors'
 import { FiatExchangeFlow } from 'src/fiatExchanges/utils'
 import { initI18n } from 'src/i18n'
@@ -96,7 +96,7 @@ describe('handleDeepLink', () => {
     }
 
     const params = new URLSearchParams(data)
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/pay?${params.toString()}`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/pay?${params.toString()}`
 
     await expectSaga(handleDeepLink, openDeepLink(deepLink))
       .provide([
@@ -113,7 +113,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles cash in deep link', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/cashIn`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/cashIn`
     await expectSaga(handleDeepLink, openDeepLink(deepLink))
       .provide([[select(walletAddressSelector), mockAccount]])
       .run()
@@ -128,7 +128,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles Bidali deep link', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/bidali`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/bidali`
     await expectSaga(handleDeepLink, openDeepLink(deepLink))
       .provide([[select(walletAddressSelector), mockAccount]])
       .run()
@@ -141,7 +141,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles cash-in-success deep link', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/cash-in-success/simplex`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/cash-in-success/simplex`
     await expectSaga(handleDeepLink, openDeepLink(deepLink))
       .provide([[select(walletAddressSelector), mockAccount]])
       .run()
@@ -154,7 +154,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles cash-in-success deep link with query params', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/cash-in-success/simplex?isApproved=true`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/cash-in-success/simplex?isApproved=true`
     await expectSaga(handleDeepLink, openDeepLink(deepLink))
       .provide([[select(walletAddressSelector), mockAccount]])
       .run()
@@ -167,7 +167,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles openScreen deep link with safe origin', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/openScreen?screen=${Screens.FiatExchangeCurrency}&flow=CashIn`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/openScreen?screen=${Screens.FiatExchangeCurrency}&flow=CashIn`
     await expectSaga(handleDeepLink, openDeepLink(deepLink, true))
       .provide([[select(walletAddressSelector), mockAccount]])
       .run()
@@ -183,7 +183,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles openScreen deep link without safe origin', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/openScreen?screen=${Screens.FiatExchangeCurrency}&flow=CashIn`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/openScreen?screen=${Screens.FiatExchangeCurrency}&flow=CashIn`
     await expectSaga(handleDeepLink, openDeepLink(deepLink, false))
       .provide([[select(walletAddressSelector), mockAccount]])
       .run()
@@ -232,7 +232,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles jumpstart links', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/jumpstart/0xPrivateKey/celo-alfajores`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/jumpstart/0xPrivateKey/celo-alfajores`
     jest.mocked(getDynamicConfigParams).mockReturnValue({
       jumpstartContracts: {
         [NetworkId['celo-alfajores']]: { contractAddress: '0xTEST' },
@@ -263,7 +263,7 @@ describe('handleDeepLink', () => {
   })
 
   it('Handles hooks enable preview links', async () => {
-    const deepLink = `${DEEPLINK_PREFIX}://wallet/hooks/enablePreview?hooksApiUrl=https://192.168.0.42:18000`
+    const deepLink = `${DEEP_LINK_PREFIX}://wallet/hooks/enablePreview?hooksApiUrl=https://192.168.0.42:18000`
     await expectSaga(handleDeepLink, openDeepLink(deepLink))
       .provide([
         [select(allowHooksPreviewSelector), true],
@@ -298,7 +298,7 @@ describe('WalletConnect deeplinks', () => {
     },
     {
       name: 'iOS deeplink',
-      link: `${DEEPLINK_PREFIX}://wallet/wc?uri=${connectionString}`,
+      link: `${DEEP_LINK_PREFIX}://wallet/wc?uri=${connectionString}`,
     },
     {
       name: 'iOS universal link',
@@ -376,7 +376,7 @@ describe('WalletConnect deeplinks', () => {
   const actionString = 'wc:1234'
   const actionLinks = [
     { name: 'Android', link: actionString },
-    { name: 'iOS deeplink', link: `${DEEPLINK_PREFIX}://wallet/wc?uri=${actionString}` },
+    { name: 'iOS deeplink', link: `${DEEP_LINK_PREFIX}://wallet/wc?uri=${actionString}` },
     { name: 'iOS universal link', link: `https://valoraapp.com/wc?uri=${actionString}` },
   ]
   for (const { name, link } of actionLinks) {
@@ -419,7 +419,7 @@ describe('handleOpenUrl', () => {
 
   const httpLink = 'http://example.com'
   const httpsLink = 'https://example.com'
-  const appLink = `${DEEPLINK_PREFIX}://something`
+  const appLink = `${DEEP_LINK_PREFIX}://something`
   const otherDeepLink = 'other://deeplink'
 
   describe('when openExternal is `false` or not specified', () => {

src/config.ts

@@ -69,6 +69,7 @@ export const DEFAULT_FORNO_URL =
     : 'https://alfajores-forno.celo-testnet.org/'
 
 export const APP_BUNDLE_ID = configOrThrow('APP_BUNDLE_ID')
+export const DEEP_LINK_PREFIX = configOrThrow('DEEP_LINK_PREFIX')
 
 // The network that FiatConnect providers operate on
 export const FIATCONNECT_NETWORK =
@@ -161,12 +162,6 @@ export const SUPERCHARGE_LOGO_URL =
 export const SIMPLEX_FEES_URL =
   'https://support.simplex.com/hc/en-gb/articles/360014078420-What-fees-am-I-paying-'
 
-// N.B.: Make sure to update the following files to match this value:
-// * app.json
-// * android/**/AndroidManifest.xml
-// * ios/**/AppDelegate.mm
-export const DEEPLINK_PREFIX = 'celo'
-
 export const APP_STORE_ID = Config.APP_STORE_ID
 export const DYNAMIC_LINK_DOMAIN_URI_PREFIX = 'https://vlra.app'
 export const CROWDIN_DISTRIBUTION_HASH = 'e-f9f6869461793b9d1a353b2v7c'

src/dapps/saga.test.ts

@@ -1,6 +1,7 @@
 import { FetchMock } from 'jest-fetch-mock/types'
 import { expectSaga } from 'redux-saga-test-plan'
 import { select } from 'redux-saga/effects'
+import { DEEP_LINK_PREFIX } from 'src/config'
 import { handleFetchDappsList, handleOpenDapp } from 'src/dapps/saga'
 import { dappsListApiUrlSelector, dappsWebViewEnabledSelector } from 'src/dapps/selectors'
 import { dappSelected, fetchDappsListCompleted, fetchDappsListFailed } from 'src/dapps/slice'
@@ -11,7 +12,6 @@ import { Screens } from 'src/navigator/Screens'
 import { getExperimentParams } from 'src/statsig'
 import { walletAddressSelector } from 'src/web3/selectors'
 import { mockAccount } from 'test/values'
-import { DEEPLINK_PREFIX } from 'src/config'
 
 jest.mock('src/statsig')
 
@@ -45,7 +45,7 @@ describe('Dapps saga', () => {
         dappSelected({
           dapp: {
             ...baseDapp,
-            dappUrl: `${DEEPLINK_PREFIX}://wallet/bidali`,
+            dappUrl: `${DEEP_LINK_PREFIX}://wallet/bidali`,
             openedFrom: DappSection.All,
           },
         })

src/dapps/selectors.test.ts

@@ -1,10 +1,10 @@
+import { DEEP_LINK_PREFIX } from 'src/config'
 import {
   dappCategoriesSelector,
   dappListWithCategoryNamesSelector,
   favoriteDappsWithCategoryNamesSelector,
 } from 'src/dapps/selectors'
 import { getMockStoreData } from 'test/utils'
-import { DEEPLINK_PREFIX } from 'src/config'
 
 const dapp1V2 = {
   name: 'Ubeswap',
@@ -21,7 +21,7 @@ const dapp2V2 = {
   categories: ['2'],
   description: 'Lend and borrow tokens!',
   iconUrl: 'https://raw.githubusercontent.com/app-list/main/assets/moola.png',
-  dappUrl: `${DEEPLINK_PREFIX}://wallet/moolaScreen`,
+  dappUrl: `${DEEP_LINK_PREFIX}://wallet/moolaScreen`,
 }
 
 const dappsCategories = [

src/fiatExchanges/SimplexScreen.tsx

@@ -5,14 +5,14 @@ import { useTranslation } from 'react-i18next'
 import { ActivityIndicator, StyleSheet, View } from 'react-native'
 import { e164NumberSelector } from 'src/account/selectors'
 import { showError } from 'src/alert/actions'
-import { FiatExchangeEvents } from 'src/analytics/Events'
 import AppAnalytics from 'src/analytics/AppAnalytics'
+import { FiatExchangeEvents } from 'src/analytics/Events'
 import { ErrorMessages } from 'src/app/ErrorMessages'
 import { phoneNumberVerifiedSelector } from 'src/app/selectors'
 import BackButton from 'src/components/BackButton'
 import Button, { BtnSizes } from 'src/components/Button'
 import WebView from 'src/components/WebView'
-import { SIMPLEX_FEES_URL } from 'src/config'
+import { DEEP_LINK_PREFIX, SIMPLEX_FEES_URL } from 'src/config'
 import ReviewFees from 'src/fiatExchanges/ReviewFees'
 import { fetchSimplexPaymentData } from 'src/fiatExchanges/utils'
 import i18n from 'src/i18n'
@@ -27,7 +27,6 @@ import { useTokenInfo } from 'src/tokens/hooks'
 import { resolveCurrency } from 'src/utils/currencies'
 import { navigateToURI } from 'src/utils/linking'
 import { currentAccountSelector } from 'src/web3/selectors'
-import { DEEPLINK_PREFIX } from 'src/config'
 
 type RouteProps = NativeStackScreenProps<StackParamList, Screens.Simplex>
 type Props = RouteProps
@@ -59,7 +58,7 @@ function SimplexScreen({ route, navigation }: Props) {
   const onNavigationStateChange = ({ url }: any) => {
     if (url?.includes('/payments/new')) {
       setRedirected(true)
-    } else if (url?.startsWith(`${DEEPLINK_PREFIX}://wallet`)) {
+    } else if (url?.startsWith(`${DEEP_LINK_PREFIX}://wallet`)) {
       navigateToURI(url)
     }
   }

src/firebase/notifications.test.ts

@@ -4,14 +4,14 @@ import { expectSaga } from 'redux-saga-test-plan'
 import { select } from 'redux-saga/effects'
 import { showMessage } from 'src/alert/actions'
 import { openUrl } from 'src/app/actions'
+import { DEEP_LINK_PREFIX } from 'src/config'
 import { handleNotification } from 'src/firebase/notifications'
 import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
 import { NotificationReceiveState, NotificationTypes } from 'src/notifications/types'
 import { recipientInfoSelector } from 'src/recipients/reducer'
 import { NetworkId, TransactionStatus } from 'src/transactions/types'
 import { mockRecipientInfo } from 'test/values'
-import { DEEPLINK_PREFIX } from 'src/config'
 
 describe(handleNotification, () => {
   beforeEach(() => {
@@ -80,7 +80,7 @@ describe(handleNotification, () => {
   })
 
   describe("with a notification with an 'open url' semantic and a deep link", () => {
-    const expectedUrl = `${DEEPLINK_PREFIX}://wallet/openScreen?screen=${Screens.TabNavigator}`
+    const expectedUrl = `${DEEP_LINK_PREFIX}://wallet/openScreen?screen=${Screens.TabNavigator}`
     const message: FirebaseMessagingTypes.RemoteMessage = {
       notification: { title: 'My title', body: 'My Body' },
       data: { ou: expectedUrl },

src/home/reducers.test.ts

@@ -1,3 +1,4 @@
+import { DEEP_LINK_PREFIX } from 'src/config'
 import {
   Actions,
   celebratedNftFound,
@@ -16,7 +17,6 @@ import {
 } from 'src/home/reducers'
 import { NetworkId } from 'src/transactions/types'
 import { mockCleverTapInboxMessage, mockContractAddress } from 'test/values'
-import { DEEPLINK_PREFIX } from 'src/config'
 
 const createTestNotification = (body: string) => ({
   ctaUri: 'https://celo.org',
@@ -31,7 +31,7 @@ const createTestNotification = (body: string) => ({
 })
 
 const mockRewardProperties = {
-  deepLink: `${DEEPLINK_PREFIX}://test`,
+  deepLink: `${DEEP_LINK_PREFIX}://test`,
   rewardExpirationDate: '3000-12-01T00:00:00.000Z',
   rewardReminderDate: '3000-01-01T00:00:00.000Z',
 }