Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timeouts methods to Client #1096

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Timeouts methods to Client #1096

wants to merge 1 commit into from

Conversation

erikdubbelboer
Copy link
Collaborator

The current Timeout/Deadline methods starting a new goroutine is
something most users don't seem to understand. They also don't get the
performance implications of using this vs setting a
ReadTimeout/WriteTimeout.

Setting A ReadTimeout/WriteTimeout is always better. Maybe we shoud
deprecate the old methods.

The current Timeout/Deadline methods starting a new goroutine is
something most users don't seem to understand. They also don't get the
performance implications of using this vs setting a
ReadTimeout/WriteTimeout.

Setting A ReadTimeout/WriteTimeout is always better. Maybe we shoud
deprecate the old methods.
@erikdubbelboer
Copy link
Collaborator Author

@kirillDanshin @valyala what do you think of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant