Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Timeouts methods to Client #1096

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Timeouts methods to Client #1096

wants to merge 1 commit into from

Commits on Sep 9, 2021

  1. Add Timeouts methods to Client 

    The current Timeout/Deadline methods starting a new goroutine is
something most users don't seem to understand. They also don't get the
performance implications of using this vs setting a
ReadTimeout/WriteTimeout.

Setting A ReadTimeout/WriteTimeout is always better. Maybe we shoud
deprecate the old methods.
    @erikdubbelboer
    erikdubbelboer committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    95f636c View commit details
    Browse the repository at this point in the history