Skip to content

feat: starting out with v1 API OpenAPI (#492) #265

feat: starting out with v1 API OpenAPI (#492)

feat: starting out with v1 API OpenAPI (#492) #265

Triggered via push July 19, 2024 08:54
Status Success
Total duration 35s
Artifacts
release-please
24s
release-please
cargo-release
0s
cargo-release
container-release
0s
container-release
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
release-please
Unexpected input(s) 'package-name', valid inputs are ['token', 'release-type', 'path', 'target-branch', 'config-file', 'manifest-file', 'repo-url', 'github-api-url', 'github-graphql-url', 'fork', 'include-component-in-tag', 'proxy-server', 'skip-github-release', 'skip-github-pull-request', 'changelog-host']
large size difference between variants: src/main.rs#L328
warning: large size difference between variants --> src/main.rs:328:1 | 328 | / enum ServerCommands { 329 | | /// "run" sub command. 330 | | Run(server::run::Args), | | ---------------------- the largest variant contains at least 344 bytes 331 | | /// Dump the schema. 332 | | Schema(crate::server::schema::Args), | | ----------------------------------- the second-largest variant contains at least 24 bytes 333 | | } | |_^ the entire enum is at least 344 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 330 | Run(Box<server::run::Args>), | ~~~~~~~~~~~~~~~~~~~~~~
useless conversion to the same type: `pbs::common::versions::VersionSpec`: src/server/run/versions.rs#L181
warning: useless conversion to the same type: `pbs::common::versions::VersionSpec` --> src/server/run/versions.rs:181:35 | 181 | version_spec: with_version.version_spec.clone().into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `with_version.version_spec.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
using `clone` on type `AnnoDb` which implements the `Copy` trait: src/server/run/versions.rs#L180
warning: using `clone` on type `AnnoDb` which implements the `Copy` trait --> src/server/run/versions.rs:180:31 | 180 | database: anno_db.clone(), | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `anno_db` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/server/run/versions.rs#L91
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/server/run/versions.rs:91:5 | 91 | impl Into<pbs::common::versions::VersionSpec> for VersionSpec { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<server::run::versions::schema::VersionSpec>` | 91 ~ impl From<VersionSpec> for pbs::common::versions::VersionSpec { 92 ~ fn from(val: VersionSpec) -> Self { 93 ~ let VersionSpec { 94 | identifier, ... 104| created_from, 105~ } = val; |
the borrowed expression implements the required traits: src/server/run/versions.rs#L84
warning: the borrowed expression implements the required traits --> src/server/run/versions.rs:84:52 | 84 | let yaml_str = std::fs::read_to_string(&full_path) | ^^^^^^^^^^ help: change this to: `full_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/server/run/versions.rs#L28
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/server/run/versions.rs:28:5 | 28 | impl Into<pbs::common::versions::CreatedFrom> for CreatedFrom { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<server::run::versions::schema::CreatedFrom>` | 28 ~ impl From<CreatedFrom> for pbs::common::versions::CreatedFrom { 29 ~ fn from(val: CreatedFrom) -> Self { 30 ~ let CreatedFrom { name, version } = val; |