Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from attrs to pydantic #166

Closed
holtgrewe opened this issue Dec 10, 2023 · 0 comments · Fixed by #168
Closed

Switch from attrs to pydantic #166

holtgrewe opened this issue Dec 10, 2023 · 0 comments · Fixed by #168
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
While attrs is nice for writing data classes, it does not offer the validation that pydantic does.

Describe the solution you'd like
Switch to modern pydantic code.

Describe alternatives you've considered
N/A

Additional context
N/A
@holtgrewe holtgrewe added the enhancement New feature or request label Dec 10, 2023
holtgrewe added a commit that referenced this issue Dec 10, 2023
@holtgrewe
feat: switch from attrs to pydantic (#166)
de8480d 
work in progres
@holtgrewe holtgrewe linked a pull request Dec 11, 2023 that will close this issue
feat: switch from attrs to pydantic (#166) #168
Merged
holtgrewe added a commit that referenced this issue Dec 11, 2023
@holtgrewe
feat: switch from attrs to pydantic (#166) (#168)
d84db77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: switch from attrs to pydantic (#166) varfish-org/clinvar-this
1 participant
@holtgrewe