Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not report deleted or duplicated reference in hgvs.c notation #199

Closed
wants to merge 2 commits into from

Conversation

tedil
Copy link
Contributor

@tedil tedil commented Jul 31, 2024

See https://hgvs-nomenclature.org/stable/background/simple/ (especially "sometimes misreported as" comments)

@tedil tedil requested a review from holtgrewe July 31, 2024 11:27
@holtgrewe
Copy link
Contributor

Hm, this is what NoRef<> is for.

/// Newtype that allows to suppress printing of reference bases.

@tedil
Copy link
Contributor Author

tedil commented Jul 31, 2024

Hm, this is what NoRef<> is for.

/// Newtype that allows to suppress printing of reference bases.

ah okay, then we'd better use that

@tedil
Copy link
Contributor Author

tedil commented Jul 31, 2024

Not needed, simply use NoRef newtype in mehari

@tedil tedil closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants