Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OpenAPI for /api/v1/genes/transcripts (#628) #629

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

holtgrewe
Copy link
Contributor

@holtgrewe holtgrewe commented Nov 21, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new API endpoint /api/v1/genes/transcripts for querying gene transcripts.
    • Added several new data schemas to enhance response structures and query capabilities.
  • Documentation

    • Updated OpenAPI documentation to reflect new endpoints and data structures, improving API usability.
  • Bug Fixes

    • Enhanced visibility of key structures and enums to ensure accessibility across modules, improving functionality.

@holtgrewe holtgrewe linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the OpenAPI schema from version 0.29.6 to 0.30.0, adding a new GET endpoint /api/v1/genes/transcripts for querying gene transcripts. This endpoint requires parameters like hgnc_id and genome_build, and introduces several new schemas in the components section. Additionally, visibility of relevant structures and enums in the Actix server implementation is modified to pub(crate), enhancing accessibility. The server's module imports and OpenAPI documentation are also updated to reflect these changes.

Changes

File Path Change Summary
openapi.schema.yaml - Added endpoint /api/v1/genes/transcripts with GET method.
- Introduced schemas: ExonAlignment, GenesTranscriptsListQuery, GenesTranscriptsListResponse, GenomeAlignment, Strand, Transcript, TranscriptBiotype, TranscriptTag.
src/server/run/actix_server/gene_txs.rs - Changed visibility of structures and enums related to gene transcripts to pub(crate).
- Added utoipa::IntoParams derive macro to GenesTranscriptsListQuery.
- Updated handle_with_openapi function to include the query struct.
src/server/run/mod.rs - Added imports for new types from actix_server::gene_txs.
- Updated ApiDoc to include new paths for gene transcript handling.
- Expanded OpenAPI documentation components with new types.

Possibly related PRs

🐰 In the garden where genes align,
New endpoints sprout, oh how they shine!
Transcripts dance with data bright,
In the API, a joyful sight!
With schemas new, our paths expand,
Hopping forth, we take a stand! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@holtgrewe holtgrewe merged commit d155620 into main Nov 21, 2024
8 of 9 checks passed
@holtgrewe holtgrewe deleted the 628-gene-transcripts-openapi-output-missing branch November 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gene transcripts OpenAPI output missing
1 participant