-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bloom Filter :: Extend bloom to inject a block #369
Comments
@darrenvechain is the idea to construct a bloom filter looking at the outputs of each transaction? Here is an example of the response of the block endpoint with
For VET transfers it's easily checked for the |
Ya if you look at the thor code base, you can see which parts of txs / blocks get added to the beat2 bloom |
Nice! Makes sense @darrenvechain |
Working on branch at Hash functions secured in
|
The logic is to derive the Bloom's filter from the addresses described in the properties of The SDK should provide two methods in
|
For
IMPORTANTSince addresses are hexadecimal expressions but those can be expressed in the checksummed format described in ethereum/EIPs#55, its is mandatory the Bloom's filter is build on the base of the byte array of the hexadecimal expression of addresses. |
Pure and secure code. The The method
assuming some default parameters are set, see below. Unfortunately two Bloom filters derived by blocks are useless if the To test the same address against different filters from different blocks - those must have Because what above, after some mathematic experimentation, I derived k = 5 as default parameter for However since we do not provides any mean to derive |
* feat: #369 hash functions secured * feat: #369 wip * feat: #369 wip * feat: #369 wip * feat: #369 wip * feat: #369 wip * feat: #369: bloomUtil exposes addressOf and filterOf methods to build from ExpandedBlockDetail * feat: #369: bloomUtil exposes addressOf and filterOf methods to build from ExpandedBlockDetail * feat: #369: bloomUtil exposes addressOf and filterOf methods to build from ExpandedBlockDetail * feat: #369: bloomUtil exposes addressOf and filterOf methods to build from ExpandedBlockDetail * feat: #369: bloomUtil exposes addressOf and filterOf methods to build from ExpandedBlockDetail --------- Co-authored-by: rodolfopietro97 <rodolfo@rodolfopietro.it>
* refactor: #666 pure and secure hashing, secp256k and bloom functions * refactor: #666 pure and secure hashing, secp256k and bloom functions * refactor: #666 pure & secure hashing, secp256k and bloom functions, reworking docs * refactor: #666 pure & secure hashing, secp256k and bloom functions, docs fixed * refactor: #666 pure & secure hashing, secp256k and bloom functions, docs fixed * refactor: #666 pure & secure hashing, secp256k and bloom functions, docs fixed * refactor: #666 pure & secure hashing, secp256k and bloom functions, docs fixed * refactor: #666 pure & secure hashing, secp256k and bloom functions, docs fixed * refactor: #369 wip * refactor: #666: address.ts pure&secure wip * refactor: #666: pure and secure packages/core/src/address/address.ts * refactor: #666: pure and secure packages/core/src/address/address.ts * refactor: #666: pure and secure packages/core/src/address/address.ts * refactor: #666: pure and secure packages/core/src/address/address.ts * refactor: #666: pure and secure packages/core/src/address/address.ts
As a developer, I want to pass an
ExtendedBlock
into bloom so that I can check for addressesThe current bloom filter is generic and hard to use. I would propose extending it to accept an expanded block (or the outputs of an expanded block) ie.:
The text was updated successfully, but these errors were encountered: