Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

666 address pure and secure #804

Merged
merged 19 commits into from
Apr 19, 2024
Merged

666 address pure and secure #804

merged 19 commits into from
Apr 19, 2024

Conversation

lucanicoladebiasi
Copy link
Collaborator

Description

The functionalities provided by packages/core/src/address/address.ts is pure (browser of NodeJS agnostic) and secure (cryptographic/hash algorythom can be pass a secure audit).

Functions returning addresses alwais return them in the canonical form reccomanded by https://eips.ethereum.org/EIPS/eip-55.

The addressUtils.toChecksummed is renamed addressUtils.toERC55Checksum in analogy with analogous functions provided by the BitCoin foundation, the Ethereum Doundation and the ethers library.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • yarn test:examples
  • yarn test:solo
  • yarn test:unit

Test Configuration:

  • Node.js Version: v21.6.2
  • Yarn Version: 1.22.21

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@lucanicoladebiasi
refactor: #666 pure and secure hashing, secp256k and bloom functions
02a6a6c
@lucanicoladebiasi
refactor: #666 pure and secure hashing, secp256k and bloom functions
8c0892c
@lucanicoladebiasi
Merge branch 'main' into 666-bloom-hash-secp256k1-pure-and-secure
5cc8187
@lucanicoladebiasi
refactor: #666 pure & secure hashing, secp256k and bloom functions, r…
f7d48b6 
…eworking docs
@lucanicoladebiasi
refactor: #666 pure & secure hashing, secp256k and bloom functions, d…
8f38ab5 
…ocs fixed
@lucanicoladebiasi
refactor: #666 pure & secure hashing, secp256k and bloom functions, d…
a590387 
…ocs fixed
@lucanicoladebiasi
refactor: #666 pure & secure hashing, secp256k and bloom functions, d…
e06873f 
…ocs fixed
@lucanicoladebiasi
Merge branch 'main' into 666-bloom-hash-secp256k1-pure-and-secure
6620abe
@lucanicoladebiasi
refactor: #666 pure & secure hashing, secp256k and bloom functions, d…
6d154e8 
…ocs fixed
@lucanicoladebiasi
refactor: #666 pure & secure hashing, secp256k and bloom functions, d…
8d70c33 
…ocs fixed
@lucanicoladebiasi
refactor: #369 wip
f3ee688
@lucanicoladebiasi
Merge branch 'refs/heads/main' into 666-address-pure-and-secure
362143e 
# Conflicts:
#	apps/sdk-node-integration/yarn.lock
#	packages/core/src/bloom/bloom.ts
#	packages/core/src/hash/blake2b256.ts
#	packages/network/tests/provider/fixture.ts
#	packages/wallet/tests/base-wallet/fixture.ts
@lucanicoladebiasi
refactor: #666: address.ts pure&secure wip
63ee8bf
@lucanicoladebiasi
refactor: #666: pure and secure packages/core/src/address/address.ts
8ed5584
@lucanicoladebiasi
refactor: #666: pure and secure packages/core/src/address/address.ts
1a9e305
@lucanicoladebiasi
refactor: #666: pure and secure packages/core/src/address/address.ts
4ff5ba9
@lucanicoladebiasi
refactor: #666: pure and secure packages/core/src/address/address.ts
90dceea
@lucanicoladebiasi
Merge branch 'refs/heads/main' into 666-address-pure-and-secure
08f8c78
@lucanicoladebiasi lucanicoladebiasi self-assigned this Apr 18, 2024
@lucanicoladebiasi lucanicoladebiasi requested a review from a team as a code owner April 18, 2024 18:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
 99.87% (3086/3090) 100% (647/647) 100% (647/647)
Title Tests Skipped Failures Errors Time
core 451 0 💤 0 ❌ 0 🔥 1m 2s ⏱️
network 574 0 💤 0 ❌ 0 🔥 3m 24s ⏱️
errors 48 0 💤 0 ❌ 0 🔥 12.962s ⏱️

fabiorigam
fabiorigam requested changes Apr 18, 2024
View reviewed changes
packages/core/README.md Outdated Show resolved Hide resolved
@fabiorigam fabiorigam merged commit b27bb34 into main Apr 19, 2024
11 checks passed
@fabiorigam fabiorigam deleted the 666-address-pure-and-secure branch April 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiorigam fabiorigam fabiorigam approved these changes

Assignees

@lucanicoladebiasi lucanicoladebiasi

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanicoladebiasi @fabiorigam