Skip to content

Commit

Permalink
Store captures in a single artifact (#9873)
Browse files Browse the repository at this point in the history
This commit attempts to store soak captures in a single artifact, ideally
allowing us to process them in one shot in the service of #9622. Even if that
doesn't pan out these will still be easier to pull for later analysis in a
single artifact.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
  • Loading branch information
blt authored Nov 3, 2021
1 parent 28bae91 commit 52efa30
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/soak.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@ jobs:

- name: Run baseline experiment
run: |
rm -rf /tmp/${{ matrix.target }}/
mkdir -p /tmp/${{ matrix.target }}/
./soaks/bin/soak_one.sh "false" ${{ matrix.target }} "baseline" `cat baseline-soak/tag` /tmp/${{ matrix.target }}
rm -rf /tmp/${{ github.event.number }}/${{ matrix.target }}/
mkdir -p /tmp/${{ github.event.number }}/${{ matrix.target }}/
./soaks/bin/soak_one.sh "false" ${{ matrix.target }} "baseline" `cat baseline-soak/tag` /tmp/${{ github.event.number }}/${{ matrix.target }}
- name: Upload timing captures
uses: actions/upload-artifact@v1
with:
name: ${{ matrix.target}}-captures
path: /tmp/${{ matrix.target }}
name: ${{ github.event.number }}-captures
path: /tmp/${{ github.event.number }}

soak-comparison:
name: Soak (${{ matrix.target }}) - comparison
Expand All @@ -201,15 +201,15 @@ jobs:

- name: Run comparison experiment
run: |
rm -rf /tmp/${{ matrix.target }}/
mkdir -p /tmp/${{ matrix.target }}/
./soaks/bin/soak_one.sh "false" ${{ matrix.target }} "comparison" "${{ github.sha }}-${{ github.sha }}" /tmp/${{ matrix.target }}
rm -rf /tmp/${{ github.event.number }}/${{ matrix.target }}/
mkdir -p /tmp/${{ github.event.number }}/${{ matrix.target }}/
./soaks/bin/soak_one.sh "false" ${{ matrix.target }} "comparison" "${{ github.sha }}-${{ github.sha }}" /tmp/${{ github.event.number }}/${{ matrix.target }}
- name: Upload timing captures
uses: actions/upload-artifact@v1
with:
name: ${{ matrix.target}}-captures
path: /tmp/${{ matrix.target }}
name: ${{ github.event.number }}-captures
path: /tmp/${{ github.event.number }}

analyze-results:
name: Soak analysis (${{ matrix.target }})
Expand All @@ -225,11 +225,11 @@ jobs:
- name: Download captures artifact
uses: actions/download-artifact@v1
with:
name: ${{ matrix.target }}-captures
name: ${{ github.event.number }}-captures

- name: Analyze captures
run: |
./soaks/bin/analyze_experiment.sh ${{ matrix.target }}-captures
./soaks/bin/analyze_experiment.sh ${{ github.event.number }}-captures/${{ matrix.target }}
observer:
name: Build and push 'observer' to Github CR
Expand Down

0 comments on commit 52efa30

Please sign in to comment.