Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-demand trigger of remote soak for Vector PR with telemetry capture, PR feedback with extant and PR introduced soaks #9622

Closed
Tracked by #9515
blt opened this issue Oct 14, 2021 · 1 comment · Fixed by #9925
Closed
Tracked by #9515

On-demand trigger of remote soak for Vector PR with telemetry capture, PR feedback with extant and PR introduced soaks #9622

blt opened this issue Oct 14, 2021 · 1 comment · Fixed by #9925

Comments

@blt
Copy link
Contributor

blt commented Oct 14, 2021

No description provided.

@blt blt mentioned this issue Oct 14, 2021
Closed
11 tasks
@blt blt mentioned this issue Nov 1, 2021
Merged
@blt
Copy link
Contributor Author

blt commented Nov 1, 2021

So far we have automatic PR soaking, one per pushed sha with cancellation. I think we could drop the appropriate artifacts into place and have comments without much turmoil if we took the approach outlined here.

There'd be no interaction but maybe that's okay. If we have the analysis setup kick out markdown this will probably work just fine.

blt added a commit that referenced this issue Nov 2, 2021
@blt
Store captures in a single artifact
2e8ada9 
This commit attempts to store soak captures in a single artifact, ideally
allowing us to process them in one shot in the service of #9622. Even if that
doesn't pan out these will still be easier to pull for later analysis in a
single artifact.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
@blt blt mentioned this issue Nov 2, 2021
Merged
blt added a commit that referenced this issue Nov 2, 2021
@blt
Store captures in a single artifact
e7a4d1e 
This commit attempts to store soak captures in a single artifact, ideally
allowing us to process them in one shot in the service of #9622. Even if that
doesn't pan out these will still be easier to pull for later analysis in a
single artifact.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit that referenced this issue Nov 3, 2021
@blt
Store captures in a single artifact (#9873)
52efa30 
This commit attempts to store soak captures in a single artifact, ideally
allowing us to process them in one shot in the service of #9622. Even if that
doesn't pan out these will still be easier to pull for later analysis in a
single artifact.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit that referenced this issue Nov 3, 2021
@blt
Analyze all captures at once
897c056 
Building from #9873 we now perform analysis in one step over all soaks. This has
the added benefit of allowing us to compute a markdown blob for output, which
should set us up nicely for #9622.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
@blt blt mentioned this issue Nov 3, 2021
Merged
blt added a commit that referenced this issue Nov 4, 2021
@blt
Analyze all captures at once
95b096c 
Building from #9873 we now perform analysis in one step over all soaks. This has
the added benefit of allowing us to compute a markdown blob for output, which
should set us up nicely for #9622.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit that referenced this issue Nov 4, 2021
@blt
chore: Analyze all captures at once (#9888)
ac2b1f0 
Building from #9873 we now perform analysis in one step over all soaks. This has
the added benefit of allowing us to compute a markdown blob for output, which
should set us up nicely for #9622.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit that referenced this issue Nov 4, 2021
@blt
Add soak analysis as PR comment
881438a 
This commit adds an additional step to the soak analysis which comments on
pull-requests as soaks wrap up. This makes it easier for folks to see if
their change adjusts vector performance, relative to the baseline.

Closes #9622

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
@blt blt mentioned this issue Nov 4, 2021
Merged
@blt blt closed this as completed in #9925 Nov 5, 2021
blt added a commit that referenced this issue Nov 5, 2021
@blt
chore: Add soak analysis as PR comment (#9925)
9fd723f 
This commit adds an additional step to the soak analysis which comments on
pull-requests as soaks wrap up. This makes it easier for folks to see if
their change adjusts vector performance, relative to the baseline.

Closes #9622

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add soak analysis as PR comment vectordotdev/vector
1 participant
@blt