enhancement(sinks): Make adaptive concurrency the default (#8598)

Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
vectordotdev · Sep 6, 2021 · 989fc7a · 989fc7a
1 parent 2adb324
commit 989fc7a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/src/sinks/util/service/concurrency.rs b/src/sinks/util/service/concurrency.rs
@@ -27,7 +27,7 @@ impl ConcurrencyOption for Option<usize> {
 impl ConcurrencyOption for Concurrency {
     fn parse_concurrency(&self, default: &Self) -> Option<usize> {
         match self.if_none(*default) {
-            Concurrency::None => Some(1024),
+            Concurrency::None => None,
             Concurrency::Adaptive => None,
             Concurrency::Fixed(limit) => Some(limit),
         }

diff --git a/website/cue/reference/components.cue b/website/cue/reference/components.cue
@@ -369,8 +369,8 @@ components: {
 			enabled: bool
 
 			if enabled {
-				adaptive_concurrency:       bool | *false
-				concurrency:                uint64 | *1024
+				adaptive_concurrency:       bool | *true
+				concurrency:                uint64 | *null
 				rate_limit_duration_secs:   uint64 | *1
 				rate_limit_num:             uint64 | *9223372036854775807
 				retry_initial_backoff_secs: uint64 | *1

diff --git a/website/cue/reference/components/sinks.cue b/website/cue/reference/components/sinks.cue
@@ -533,14 +533,8 @@ components: sinks: [Name=string]: {
 
 								We highly recommend enabling this feature as it improves
 								performance and reliability of Vector and the systems it
-								communicates with.
-
-								To enable, set the `request.concurrency` option to `adaptive`:
-
-								```toml title="vector.toml"
-								[sinks.my-sink]
-								  request.concurrency = "adaptive"
-								```
+								communicates with. As such, we have made it the default,
+								and no further configuration is required.
 								"""
 						},
 						{