Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(sinks): Make adaptive concurrency the default #8598

Merged
merged 4 commits into from
Aug 27, 2021

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Aug 4, 2021

Signed-off-by: Bruce Guenter bruce.guenter@datadoghq.com

Closes #8226

Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. domain: sinks Anything related to the Vector's sinks labels Aug 4, 2021
@bruceg bruceg requested a review from blt August 4, 2021 23:00
@bruceg bruceg self-assigned this Aug 4, 2021
@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for vector-project ready!

🔨 Explore the source changes: 5c2ed22

🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/61290891760ed100080e384d

😎 Browse the preview: https://deploy-preview-8598--vector-project.netlify.app

Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
@bruceg bruceg requested a review from jszwedko August 27, 2021 15:35
@@ -370,7 +370,7 @@ components: {

if enabled {
adaptive_concurrency: bool | *false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
adaptive_concurrency: bool | *false
adaptive_concurrency: bool | *true

Forgot to note this too 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bruceg bruceg merged commit 8598593 into master Aug 27, 2021
@bruceg bruceg deleted the arc-default-enabled branch August 27, 2021 21:04
jdrouet pushed a commit that referenced this pull request Sep 6, 2021
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
@jszwedko jszwedko mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable ARC by default
2 participants