Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(sinks): Make adaptive concurrency the default #8598

Merged
merged 4 commits into from
Aug 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sinks/util/service/concurrency.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ impl ConcurrencyOption for Option<usize> {
impl ConcurrencyOption for Concurrency {
fn parse_concurrency(&self, default: &Self) -> Option<usize> {
match self.if_none(*default) {
Concurrency::None => Some(1024),
Concurrency::None => None,
Concurrency::Adaptive => None,
Concurrency::Fixed(limit) => Some(limit),
}
Expand Down
4 changes: 2 additions & 2 deletions website/cue/reference/components.cue
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,8 @@ components: {
enabled: bool

if enabled {
adaptive_concurrency: bool | *false
concurrency: uint64 | *1024
adaptive_concurrency: bool | *true
concurrency: uint64 | *null
rate_limit_duration_secs: uint64 | *1
rate_limit_num: uint64 | *9223372036854775807
retry_initial_backoff_secs: uint64 | *1
Expand Down
10 changes: 2 additions & 8 deletions website/cue/reference/components/sinks.cue
Original file line number Diff line number Diff line change
Expand Up @@ -531,14 +531,8 @@ components: sinks: [Name=string]: {

We highly recommend enabling this feature as it improves
performance and reliability of Vector and the systems it
communicates with.

To enable, set the `request.concurrency` option to `adaptive`:

```toml title="vector.toml"
[sinks.my-sink]
request.concurrency = "adaptive"
```
communicates with. As such, we have made it the default,
and no further configuration is required.
"""
},
{
Expand Down