chore: Analyze all captures at once #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: 5537091 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/61843627099e4e0007702351 |
|
|
spencergilbert
approved these changes
Nov 3, 2021
|
Just waiting for CI to finish on this to see the output, but the implementation looks good! |
jszwedko
reviewed
Nov 3, 2021
There was a problem hiding this comment.
It looks like the analysis is currently failing due to an unbound variable: https://github.com/vectordotdev/vector/runs/4097509002?check_suite_focus=true
|
Ah shoot. Easy to fix but it’ll have to wait until later tonight. Please feel free to push changes if you’d like.
…On Wed, Nov 3, 2021, at 14:38, Jesse Szwedko wrote:
***@***.**** commented on this pull request.
It looks like the analysis is currently failing due to an unbound variable: https://github.com/vectordotdev/vector/runs/4097509002?check_suite_focus=true
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#9888 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAA365P4RA27AGNTFFOGADUKGTXDANCNFSM5HJRRU6A>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt
force-pushed
the
analyze_whole_directory
branch
from
be205cf to
7f1a513
Compare
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
|
Nice! The output looks great. Excited to see this end up as Github comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building from #9873 we now perform analysis in one step over all soaks. This has
the added benefit of allowing us to compute a markdown blob for output, which
should set us up nicely for #9622.
Signed-off-by: Brian L. Troutwine brian@troutwine.us