feat: update build flow for svelte-kit #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
approved these changes
Jul 24, 2022
packages/svelte-vega/tsconfig.json
Outdated
| "files": ["./src/index.ts"], | ||
| "include": ["src/**/*"] | ||
| "include": ["src/**/*.ts", "src/**/*.svelte"], | ||
| "exclude": ["node_modules/*", "**/*.spec.ts"] |
There was a problem hiding this comment.
Why do we need to exclude these? Don't we want to type check them as well?
|
This pull request fixes 1 alert when merging b1021a8 into 81cf535 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging eb5914b into 81cf535 - view on LGTM.com fixed alerts:
|
domoritz
changed the title
|
This pull request fixes 1 alert when merging c08dcee into 81cf535 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 94afea0 into 81cf535 - view on LGTM.com fixed alerts:
|
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build system to work better for Svelte and SvelteKit