Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update build flow for svelte-kit #561

Merged
merged 13 commits into from
Nov 1, 2022
Merged

feat: update build flow for svelte-kit #561

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
612ff4e
build: update build flow for svelte-kit
cabreraalex Jul 24, 2022
ee565e7
fix: merge main and update versions
cabreraalex Nov 1, 2022
b0b542d
refactor: remove rollup
cabreraalex Nov 1, 2022
b1021a8
chore: upgrade deps
domoritz Nov 1, 2022
34c6a56
refactor: update sample-project
cabreraalex Nov 1, 2022
e439d2e
chore: update storybook deps
domoritz Nov 1, 2022
eb5914b
fix: readme in sample app
cabreraalex Nov 1, 2022
cc3259b
fix: fix sample project
domoritz Nov 1, 2022
5ee1198
nit: package
cabreraalex Nov 1, 2022
c08dcee
chore: clean up packages, add dep to sample project
domoritz Nov 1, 2022
82b6674
chore: remove unused files
domoritz Nov 1, 2022
64ae146
chore: rm favicon
domoritz Nov 1, 2022
94afea0
style: fix linting and lint
domoritz Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions packages/svelte-vega/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "svelte-vega",
"version": "1.1.0",
"version": "1.2.0",
"license": "BSD-3-Clause",
"description": "Convert Vega spec into Svelte component.",
"description": "Render Vega or Vega-Lite charts using a Svelte component.",
"author": "Alex Bäuerle <bauerlealex@gmail.com> (https://a13x.io)",
"keywords": [
"Vega-Lite",
Expand All @@ -14,15 +14,16 @@
"bugs": {
"url": "https://github.com/vega/svelte-vega/issues"
},
"sideEffects": false,
"type": "module",
"main": "dist/index.js",
"module": "dist/index.js",
"svelte": "dist/index.js",
"module": "dist/index.mjs",
"main": "dist/index.umd.js",
"types": "dist/ts/index.d.ts",
"types": "src/index.ts",
"scripts": {
"prebuild": "rm -rf ./dist",
"build": "rollup -c",
"dev": "rollup -c -w",
"build": "npm run build:js && npm run build:svelte",
"build:js": "tsc -p . --outDir dist/ --rootDir src/",
"build:svelte": "svelte-strip strip src/ dist",
"validate": "svelte-check --ignore dist",
"prepublishOnly": "npm run build",
"semantic-release": "semantic-release"
Expand All @@ -36,18 +37,13 @@
"vega-embed": "^6.21.0"
},
"devDependencies": {
"@rollup/plugin-commonjs": "^22.0.1",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-node-resolve": "^13.3.0",
"@rollup/plugin-typescript": "^8.3.3",
"@tsconfig/svelte": "^3.0.0",
"rollup": "^2.77.0",
"rollup-plugin-css-only": "^3.1.0",
"rollup-plugin-execute": "^1.1.1",
"rollup-plugin-svelte": "^7.1.0",
"svelte": "^3.49.0",
"svelte-check": "^2.8.0",
"svelte-preprocess": "^4.10.7"
"svelte-preprocess": "^4.10.7",
"svelte-strip": "^1.0.1",
"tslib": "^2.4.0",
"typescript": "^4.7.4"
},
"peerDependencies": {
"vega": "*",
Expand All @@ -56,4 +52,4 @@
"publishConfig": {
"access": "public"
}
}
}
48 changes: 0 additions & 48 deletions packages/svelte-vega/rollup.config.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/svelte-vega/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export { default as Vega } from "./Vega.svelte";
export { default as VegaLite } from "./VegaLite.svelte";
export * from "./types";
export * from "./types.js";
9 changes: 5 additions & 4 deletions packages/svelte-vega/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
"extends": "@tsconfig/svelte/tsconfig.json",
"compilerOptions": {
"strict": true,
"types": ["svelte"],
"noImplicitAny": true
"declaration": true,
"noImplicitAny": true,
"types": ["svelte"]
},
"files": ["./src/index.ts"],
"include": ["src/**/*"]
"include": ["src/**/*.ts", "src/**/*.svelte"],
"exclude": ["node_modules/*", "**/*.spec.ts"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to exclude these? Don't we want to type check them as well?

}