fix bug and delete String of Int and Float

[pjmd89]

repair error "cannot use float64 as Int" issue #204 and delete string into Int and Float

[StevenACoffman]

I am not sure why you removed the kind == reflect.String condition as "45.230343" strings are often how they are serialized.

[pjmd89]

the tests return an error because you are giving a string to an Int.

I removed the string from the int and float because if you set a variable as int or float you should get an int or a float, not a string, in fact, I got errors for that too. I hope it is useful for something.

[pjmd89]

still, adding the string without removing the validation on the Int, there is no problem. the bad thing is that it can return a string in an int or float.

[StevenACoffman]

With this change, the tests fail with:

--- FAIL: TestValidateVars (0.01s)
    --- FAIL: TestValidateVars/Scalars (0.00s)
        --- FAIL: TestValidateVars/Scalars/Json_Number_->_Int (0.00s)
            vars_test.go:290: 
                	Error Trace:	vars_test.go:290
                	Error:      	Expected nil, but got: &gqlerror.Error{err:error(nil), Message:"cannot use string as Int", Path:ast.Path{"variable", "var"}, Locations:[]gqlerror.Location(nil), Extensions:map[string]interface {}(nil), Rule:""}
                	Test:       	TestValidateVars/Scalars/Json_Number_->_Int
FAIL

[coveralls]

Coverage decreased (-0.1%) to 92.29% when pulling 441e566 on pjmd89:fixbug/validator into 14b8f03 on vektah:master.

[StevenACoffman]

Hi, can you fix this back?

[pjmd89]

sure!

[StevenACoffman]

So there was a small performance regression with your changes that I corrected by short circuiting for the most common cases. Thanks!