Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug and delete String of Int and Float #205

Merged
merged 11 commits into from
Apr 10, 2022
Merged

fix bug and delete String of Int and Float #205

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a059685
fix bug and delete String of Int and Float
pjmd89 Mar 8, 2022
92a9c16
fix bug and delete String of Int and Float
pjmd89 Mar 8, 2022
899fdf3
Merge commit '92a9c169f8922811d1615d0dc51abf6b5fcf734c'
pjmd89 Mar 27, 2022
d35ffe4
Merge commit '899fdf351670d592534895bb1bfde9b4f67f5f64' into fixbug/v…
pjmd89 Mar 27, 2022
20a52d0
Merge branch 'vektah:master' into master
pjmd89 Mar 27, 2022
8efc182
Merge commit '20a52d0a709c9df0a12d99d51814b5beab3cb561' into fixbug/v…
pjmd89 Mar 27, 2022
8d053e9
add string
pjmd89 Mar 27, 2022
e1babba
add changes
pjmd89 Mar 30, 2022
d8ccb8b
change module name
pjmd89 Apr 7, 2022
1b28ab3
change all module name
pjmd89 Apr 7, 2022
441e566
Add helper functions and short circuit to avoid performance regression
StevenACoffman Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions validator/vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package validator
import (
"fmt"
"reflect"
"strconv"
"strings"

"github.com/vektah/gqlparser/v2/ast"
Expand Down Expand Up @@ -132,11 +133,12 @@ func (v *varValidator) validateVarType(typ *ast.Type, val reflect.Value) (reflec
kind := val.Type().Kind()
switch typ.NamedType {
case "Int":
if kind == reflect.String || kind == reflect.Int || kind == reflect.Int32 || kind == reflect.Int64 {
_,e := strconv.ParseInt(fmt.Sprintf("%v", val.Interface()), 10, 64);
if e == nil && (kind == reflect.Int || kind == reflect.Int32 || kind == reflect.Int64 || kind == reflect.Float32 || kind == reflect.Float64){
return val, nil
}
case "Float":
if kind == reflect.String || kind == reflect.Float32 || kind == reflect.Float64 || kind == reflect.Int || kind == reflect.Int32 || kind == reflect.Int64 {
if kind == reflect.Float32 || kind == reflect.Float64 || kind == reflect.Int || kind == reflect.Int32 || kind == reflect.Int64 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why you removed the kind == reflect.String condition as "45.230343" strings are often how they are serialized.

Copy link
Contributor Author

@pjmd89 pjmd89 Mar 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests return an error because you are giving a string to an Int.

I removed the string from the int and float because if you set a variable as int or float you should get an int or a float, not a string, in fact, I got errors for that too. I hope it is useful for something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still, adding the string without removing the validation on the Int, there is no problem. the bad thing is that it can return a string in an int or float.

return val, nil
}
case "String":
Expand Down