Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-anonymous-default-export to default rule set #12291

Closed
gaearon opened this issue Apr 28, 2020 · 4 comments · Fixed by #14519
Closed

Add no-anonymous-default-export to default rule set #12291

gaearon opened this issue Apr 28, 2020 · 4 comments · Fixed by #14519
Assignees
@Timer
Milestone
iteration 4

Comments

@gaearon
Copy link
Contributor

gaearon commented Apr 28, 2020

Not sure if Next has a lint rule set, but if it does, we should add https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-anonymous-default-export.md there. See https://twitter.com/dan_abramov/status/1255237989548134405.
@Timer Timer self-assigned this Apr 28, 2020
@Timer Timer added this to the 9.4 milestone Apr 28, 2020
@Janpot
Copy link
Contributor

Janpot commented Apr 29, 2020

Haven't seen any discussion around it in this repo yet, but can eslint-plugin-react-hooks be added as well? Or are there reasons not to?

@gaearon
Copy link
Contributor Author

gaearon commented Apr 29, 2020

We should also probably fix examples like this: https://github.com/zeit/next.js/blob/master/examples/hello-world/pages/index.js

Haven't seen any discussion around it in this repo yet, but can eslint-plugin-react-hooks be added as well? Or are there reasons not to?

If Next has a rule set, this plugin 100% should be there. It's pretty vital so I'm surprised if it's not there already...

@timneutkens
Copy link
Member

Next.js doesn't have eslint built in currently, this is something the Chrome team is working on though: #11986

@Timer Timer modified the milestones: 9.4, 9.4.1, 9.4.2 May 11, 2020
@Timer Timer modified the milestones: 9.4.2, 9.4.3 May 20, 2020
@Timer Timer modified the milestones: 9.4.3, 9.4.4 May 28, 2020
@Timer Timer modified the milestones: 9.4.5, 9.x.x, iteration 3 Jun 9, 2020
@Timer Timer added point: 8 and removed point: 5 labels Jun 24, 2020
@Timer Timer mentioned this issue Jun 24, 2020
Merged
@Timer Timer modified the milestones: iteration 3, iteration 4 Jun 30, 2020
@kodiakhq kodiakhq bot closed this as completed in #14519 Jun 30, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 30, 2020
@Timer
Add no-anon-default-export Babel lint rule (#14519)
ea1f45a 
Fixes #12291 

![image](https://user-images.githubusercontent.com/616428/85499698-176b4900-b5b0-11ea-8a5d-a7f0b4c20307.png)
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@Timer @rokinsky
Add no-anon-default-export Babel lint rule (vercel#14519)
85d2c90 
Fixes vercel#12291 

![image](https://user-images.githubusercontent.com/616428/85499698-176b4900-b5b0-11ea-8a5d-a7f0b4c20307.png)
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Timer Timer

Labels
None yet
Projects
None yet
Milestone
iteration 4
Development

Successfully merging a pull request may close this issue.

Add no-anon-default-export Babel lint rule Timer/next.js
5 participants
@Timer @gaearon @Janpot @timneutkens @balazsorban44