Add no-anon-default-export Babel lint rule #14519

Timer · 2020-06-24T04:19:19Z

ijjk · 2020-06-30T05:45:49Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
buildDuration	12.1s	11.9s	-204ms
nodeModulesSize	66 MB	66 MB	⚠️ +8.2 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.958	2.001	⚠️ +0.04
/ avg req/sec	1277.04	1249.23	⚠️ -27.81
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.185	1.174	-0.01
/error-in-render avg req/sec	2109.74	2129.11	+19.37

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..769f.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
index.html gzip	951 B	951 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	943 B	943 B	✓
Overall change	2.85 kB	2.85 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
buildDuration	13.1s	12.9s	-216ms
nodeModulesSize	66 MB	66 MB	⚠️ +8.2 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..769f.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	907 kB	907 kB	✓
withRouter.js	907 kB	907 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: bc79807

ijjk · 2020-06-30T12:58:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
buildDuration	13.1s	13s	-65ms
nodeModulesSize	66 MB	66 MB	⚠️ +8.2 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.172	2.148	-0.02
/ avg req/sec	1151.2	1163.73	+12.53
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.499	1.471	-0.03
/error-in-render avg req/sec	1667.32	1699.59	+32.27

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..769f.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
index.html gzip	951 B	951 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	943 B	943 B	✓
Overall change	2.85 kB	2.85 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
buildDuration	13.9s	13.7s	-198ms
nodeModulesSize	66 MB	66 MB	⚠️ +8.2 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..769f.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js feat/no-anon-default-export	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	907 kB	907 kB	✓
withRouter.js	907 kB	907 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: b78c2eb

Fixes vercel#12291 ![image](https://user-images.githubusercontent.com/616428/85499698-176b4900-b5b0-11ea-8a5d-a7f0b4c20307.png)

angusd3v · 2020-07-22T00:03:48Z

This error is showing up on .svg files for me, using react-svg-loader. Any tips on conditionally disabling it? I believe react-svg-loader converts SVGs to default exported React components, having trouble figuring out what I can do to solve on the plugin side.

ref. #14519, #15062 Add limitation for Anonymous arrow functions.

Timer added 3 commits June 24, 2020 00:16

Add no-anon-default-export Babel lint rule

d9a5abb

Test variance

240c625

Increase timeout

c39ead1

Timer requested review from ijjk, lfades and timneutkens as code owners June 24, 2020 04:19

ijjk added the type: next label Jun 24, 2020

This comment has been minimized.

Sign in to view

Janpot previously approved these changes Jun 24, 2020

View reviewed changes

Merge branch 'canary' into feat/no-anon-default-export

4cdd69e

This comment has been minimized.

Sign in to view

timneutkens previously approved these changes Jun 29, 2020

View reviewed changes

Timer added 2 commits June 30, 2020 01:17

Fix test

f78d96e

fix test

815d575

Timer dismissed stale reviews from timneutkens and Janpot via 815d575 June 30, 2020 05:21

Timer requested review from timneutkens and Janpot June 30, 2020 05:22

This comment has been minimized.

Sign in to view

fix unit test

bc79807

Janpot approved these changes Jun 30, 2020

View reviewed changes

timneutkens approved these changes Jun 30, 2020

View reviewed changes

Merge branch 'canary' into feat/no-anon-default-export

b78c2eb

kodiakhq bot merged commit ea1f45a into vercel:canary Jun 30, 2020

Timer deleted the feat/no-anon-default-export branch June 30, 2020 13:05

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

Add no-anon-default-export Babel lint rule (vercel#14519)

85d2c90

Fixes vercel#12291 ![image](https://user-images.githubusercontent.com/616428/85499698-176b4900-b5b0-11ea-8a5d-a7f0b4c20307.png)

sphilee mentioned this pull request Nov 13, 2020

Update fast-refresh.md #18047

Merged

kodiakhq bot pushed a commit that referenced this pull request Nov 16, 2020

Update fast-refresh.md (#18047)

23111ca

ref. #14519, #15062 Add limitation for Anonymous arrow functions.

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add no-anon-default-export Babel lint rule #14519

Add no-anon-default-export Babel lint rule #14519

Timer commented Jun 24, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 30, 2020

ijjk commented Jun 30, 2020

angusd3v commented Jul 22, 2020 •

edited

Loading

Add no-anon-default-export Babel lint rule #14519

Add no-anon-default-export Babel lint rule #14519

Conversation

Timer commented Jun 24, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 30, 2020

Stats from current PR

ijjk commented Jun 30, 2020

Stats from current PR

angusd3v commented Jul 22, 2020 • edited Loading

angusd3v commented Jul 22, 2020 •

edited

Loading