Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercepting route modal does not work with basepath #52624

Closed
1 task done
Uy575 opened this issue Jul 13, 2023 · 12 comments · Fixed by #60485
Closed
1 task done

Intercepting route modal does not work with basepath #52624

Uy575 opened this issue Jul 13, 2023 · 12 comments · Fixed by #60485
Labels
area: app App directory (appDir: true) bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked Navigation Related to Next.js linking (e.g., <Link>) and navigation. please add a complete reproduction Please add a complete reproduction.

Comments

@Uy575
Copy link

Uy575 commented Jul 13, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.5.0: Thu Jun  8 22:21:34 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T8112
    Binaries:
      Node: 18.16.0
      npm: 9.5.1
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 13.4.7
      eslint-config-next: 13.4.7
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.3

Which area(s) of Next.js are affected? (leave empty if unsure)

App Router

Link to the code that reproduces this issue or a replay of the bug

Nextgram

To Reproduce

should make intercepting route keep working with basepath

Describe the Bug

i created a modal using intercepting route and parallel route but when we set basepath intercepting route stop working

Expected Behavior

modal should act as a intercepting route after a basepath added

Which browser are you using? (if relevant)

google chrome

How are you deploying your application? (if relevant)

production

NEXT-1439

@Uy575 Uy575 added the bug Issue was opened via the bug report template. label Jul 13, 2023
@Uy575 Uy575 changed the title Intercepting route modal dont work with basepath Intercepting route modal does not work with basepath Jul 13, 2023
@balazsorban44 balazsorban44 added Navigation Related to Next.js linking (e.g., <Link>) and navigation. area: app App directory (appDir: true) linear: next Confirmed issue that is tracked by the Next.js team. labels Jul 13, 2023
@BStoller
Copy link

Any updates on this? I really would like to use this routing for one of my apps.

@Uy575
Copy link
Author

Uy575 commented Aug 17, 2023

Any updates on this? I really would like to use this routing for one of my apps.

No, still not fixed. its working fine without basepath, but with basepath still broken.

@BStoller
Copy link

@balazsorban44 any suggestions on possible solutions?

@uyeong
Copy link

uyeong commented Aug 18, 2023

I'm having the same problem and it hasn't been fixed yet.

I'm hoping there's a workaround, even if it's a bit tricky.

I've created a repository that reproduces the issue.
It's https://github.com/uyeong/nextgram.

@hsuanyi-chou
Copy link

really need this feature.
When will nextjs fix this issue?

@treepo1

This comment has been minimized.

@leerob leerob added the please add a complete reproduction Please add a complete reproduction. label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

We cannot recreate the issue with the provided information. Please add a reproduction in order for us to be able to investigate.

Why was this issue marked with the please add a complete reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository (template for App Router, template for Pages Router), but you can also use these templates: CodeSandbox: App Router or CodeSandbox: Pages Router.

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue. Ensure your reproduction does not depend on secrets, 3rd party registries, private dependencies, or any other data that cannot be made public. Avoid a reproduction including a whole monorepo (unless relevant to the issue). The easier it is to reproduce the issue, the quicker we can help.

Please test your reproduction against the latest version of Next.js (next@canary) to make sure your issue has not already been fixed.

If you cannot create a clean reproduction, another way you can help the maintainers' job is to pinpoint the canary version of next that introduced the issue. Check out our releases, and try to find the first canary release that introduced the issue. This will help us narrow down the scope of the issue, and possibly point to the PR/code change that introduced it. You can install a specific version of next by running npm install next@<version>.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

What happens if I don't provide a sufficient minimal reproduction?

Issues with the please add a complete reproduction label that receives no meaningful activity (e.g. new comments with a reproduction link) are automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue with the required reproduction.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without reproduction steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@leerob
Copy link
Member

leerob commented Jan 5, 2024

Could we get a minimal reproduction? I see nextgram is linked, but there's also additional stuff added there. A minimal version would be very helpful to pinpoint the issue.

@klarstrup
Copy link

Here you go @leerob: https://github.com/klarstrup/Intercepting-route-modal-does-not-work-with-basepath

Comment or uncomment baseDir in next.config.js and visit http://localhost:3000/ or http://localhost:3000/sub-directory respectively. The prior will have the expected behavior of the links on the demonstration images will be intercepted and result shown in modal - whereas in the latter a typical navigation will happen without interception.

@samcx
Copy link
Member

samcx commented Jan 10, 2024

@klarstrup Thank you for the :repro:! I was able to replicate the issue. I will be sharing this with the team so we can take a look!

@Uy575
Copy link
Author

Uy575 commented Jan 10, 2024

@leerob @samcx hey here is your own repo nextgram https://github.com/Uy575/Next_intercepting_and_parallel_route_issue.git
i just added a next config file with basepath named "/testing".
you can comment or uncomment basepath in nextconfig file to point the issue, it has different behaviour with basepath commenting or uncommenting.

ztanner pushed a commit that referenced this issue Jan 10, 2024
### Fixing a bug

### What?
When basePath is added, intercepted routes stop working correctly.

### Why?

For them, basePath was not added at all.

### How?

Added basePath to the rewrites for intercepted routes.

Fixes #52624, #58268
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: app App directory (appDir: true) bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked Navigation Related to Next.js linking (e.g., <Link>) and navigation. please add a complete reproduction Please add a complete reproduction.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants