Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX extension support #163

Closed
wants to merge 2 commits into from
Closed

Conversation

CompuIves
Copy link
Contributor

Response to #161 in case we want to support .jsx files.

@Alfredo2519
Copy link

I dont really no wut to do here im new at this lol

@CompuIves CompuIves changed the title JSX support JSX extension support Oct 30, 2016
@rauchg
Copy link
Member

rauchg commented Nov 2, 2016

What's the advantage of supporting .jsx if we already support jsx in .js? Isn't it confusing to have two?

@skhavari
Copy link

skhavari commented Nov 2, 2016

typescript is a use case to support this. typescript will produce jsx files if you want babel to compile JSX and not typescript.

@arunoda
Copy link
Contributor

arunoda commented Nov 14, 2016

@rauchg beside what @skhavari mentioned, some still love to use .jsx extension for React.
Here's the discussion in CRA: facebook/create-react-app#87

If this helps to someone, adding .jsx support make no harm.
But we should not document it.

@rauchg
Copy link
Member

rauchg commented Nov 17, 2016

I support this since JSX is not a standard feature, and I understand that some might want to make this explicit.

@giacomorebonato
Copy link

how to understand the conflict in webpack.js ?

@rauchg
Copy link
Member

rauchg commented Nov 21, 2016

Can you elaborate?

On Mon, Nov 21, 2016 at 6:49 AM Giacomo Rebonato notifications@github.com
wrote:

how to understand the conflict in webpack.js ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#163 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAy8QhhL6AKSJ1FfcHLc1P6JCF6KlGDks5rAWkzgaJpZM4KkguK
.

@giacomorebonato
Copy link

I would like to help with this PR, but I don't know how to understand what the conflict on webpacks.js is about.
Should I checkout this branch e run the tests?

@rauchg
Copy link
Member

rauchg commented Dec 1, 2016

Closing this for the time being as we haven't heard much. @CompuIves wouldn't it be nicer to incorporate typescript support through babel / webpack decoration, rather than a separate pipeline that outputs .jsx files?

@rauchg rauchg closed this Dec 1, 2016
@CompuIves
Copy link
Contributor Author

@rauchg I agree, I now see that I also edited the gulp file which wasn't necessary at all 😅 . After we support the Webpack config PR people can just add this themselves, we could also maybe document it somewhere or create helper methods (something like addJSXSupport(webpackConfig)).

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants