Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never cache assets and HTML in the dev mode. #2045

Merged
merged 2 commits into from
May 25, 2017
Merged

Never cache assets and HTML in the dev mode. #2045

merged 2 commits into from
May 25, 2017

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented May 23, 2017

Fixes #2014

arunoda added 2 commits May 22, 2017 22:17
timneutkens
timneutkens approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@timneutkens timneutkens merged commit 9121a9d into vercel:master May 25, 2017
@arunoda arunoda deleted the no-cache-in-dev branch May 26, 2017 03:07
@arunoda arunoda mentioned this pull request Jun 9, 2017
Closed
xuezhma pushed a commit to xuezhma/next.js that referenced this pull request Jun 22, 2017
@arunoda @xuezhma
Never cache assets and HTML in the dev mode. (vercel#2045)
80c4d63 
* Never cache assets and HTML in the dev mode.

* Move etags test to the production.

Now it won't work in dev because of no-cache settings.
@lock lock bot locked as resolved and limited conversation to collaborators May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunoda @timneutkens