Add next configuration as an option for custom servers #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunoda
suggested changes
May 26, 2017
| this.http = null | ||
| this.config = getConfig(this.dir) | ||
| this.config = getConfig(this.dir, conf) |
There was a problem hiding this comment.
If we've a config via the option, it shouldn't read from the filesystem. Change the code to reflect that.
And make sure to get default configurations. May be we need to add method called withDefaults to server/config.js
There was a problem hiding this comment.
Well, for my use case, I still want to be able to read from filesystem to overwrite default & custom server.
That's why I have this order in Object.assign
Your thoughts?
arunoda
approved these changes
May 31, 2017
|
@reel everything looks great to me. Let's wait for tests. |
|
Actually the error is not our fault. So. I'm taking this in. |
|
Thank's @arunoda Here's a peak at what we can do now: https://github.com/usehenri/henri/blob/master/packages/view/conf.js |
xuezhma
pushed a commit
to xuezhma/next.js
that referenced
this pull request
Jun 22, 2017
* Add a configuration parameter to custom server startup * Adding related documentation * Do not access filesystem if configuration is supplied * Make the configuration log clearer * Make the conf default value to `null`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a
next.config.jsfile, we can dynamically add configuration from the custom server.The use case would be to support many different webpack configuration with a
minimistflag.I can add an example if wanted.